Fix regression on fast/table/table-row-compositing-repaint-crash.html
authorshawnsingh@chromium.org <shawnsingh@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Mar 2012 19:24:45 +0000 (19:24 +0000)
committershawnsingh@chromium.org <shawnsingh@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Mar 2012 19:24:45 +0000 (19:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/platform/qt/Skipped
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayerCompositor.cpp

index 871089c6a2eb22020b6e32e96f5753991cb05355..bbc44b5aabd06c247452818a9b3698afc83c541d 100644 (file)
@@ -3937,7 +3937,6 @@ BUGWK80665 : fast/js/string-replace-2.html = TEXT
 BUGABARTH SNOWLEOPARD : fast/events/input-image-scrolled-x-y.html = PASS CRASH
 
 BUGWK80801 : fast/js/function-constructor-error.html = TEXT
-BUGWK80804 DEBUG : fast/table/table-row-compositing-repaint-crash.html = CRASH
 
 BUGWK80807 MAC : fast/events/invalid-001.html = PASS CRASH
 BUGWK80807 MAC : fast/events/invalid-002.html = PASS CRASH
index bd2e9ed3899bad80a3bf0dc8861b5bb1bd3bb201..1d6624796027f82a5067512f7c0a11289325c9b1 100644 (file)
@@ -2740,7 +2740,3 @@ fast/events/dispatch-message-string-data.html
 # https://bugs.webkit.org/show_bug.cgi?id=75568
 plugins/mouse-click-plugin-clears-selection.html
 fast/events/mouse-relative-position.html
-
-# [Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
-# https://bugs.webkit.org/show_bug.cgi?id=80833
-fast/table/table-row-compositing-repaint-crash.html
index 5839abd1d186d7a353008abfd8fc579a632f6016..db48fabefb7d9a7b8f37ce07bb3e55058f638ff7 100644 (file)
@@ -1,3 +1,18 @@
+2012-03-11  Shawn Singh  <shawnsingh@chromium.org>
+
+        Fix regression on fast/table/table-row-compositing-repaint-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=80804
+
+        Reviewed by Simon Fraser.
+
+        Covered by existing tests.
+
+        http://trac.webkit.org/changeset/110401/ accidentally caused
+        fast/table/table-row-compositing-repaint-crash.html to fail.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateBacking):
+
 2012-03-12  Mike Lawther  <mikelawther@chromium.org>
 
         CSS3 calc: enable mixed percent/absolute for font
index dbcbf2158936b5e2aa96f9133327f7d291619eb8..21d468022029fcf7bf39505ed29584207781bfc0 100644 (file)
@@ -420,7 +420,8 @@ bool RenderLayerCompositor::updateBacking(RenderLayer* layer, CompositingChangeR
             // The RenderLayer's needs to update repaint rects here, because the target
             // repaintContainer may have changed after becoming a composited layer.
             // https://bugs.webkit.org/show_bug.cgi?id=80641
-            layer->computeRepaintRects();
+            if (layer->parent())
+                layer->computeRepaintRects();
 
 #if PLATFORM(MAC) && USE(CA)
             Settings* settings = m_renderView->document()->settings();