2009-11-11 Daniel Bates <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31326

        Makes the output for test fast/events/drag-and-drop.html pretty.
        Now, it is easier to read for a human to read understand the results.

        * fast/events/drag-and-drop-expected.txt: Rebased result.
        * fast/events/drag-and-drop.html: Modified to make the output pretty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 75414f416486f36b0d9ea3087712f4f407560ad2..3c358019619c460ad8800d33460f77a5ebe7cd87 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2009-11-11  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31326
+
+        Makes the output for test fast/events/drag-and-drop.html pretty.
+        Now, it is easier to read for a human to read understand the results.
+
+        * fast/events/drag-and-drop-expected.txt: Rebased result.
+        * fast/events/drag-and-drop.html: Modified to make the output pretty.
+
 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
 
         Reviewed by Oliver Hunt.

diff --git a/LayoutTests/fast/events/drag-and-drop-expected.txt b/LayoutTests/fast/events/drag-and-drop-expected.txt
index 586ea0e81c9fd09755bfcb4ae112ad6609b4c664..f600d3a954a2099cdcc47f77e0ecabf870673cc1 100644 (file)
--- a/LayoutTests/fast/events/drag-and-drop-expected.txt
+++ b/LayoutTests/fast/events/drag-and-drop-expected.txt
@@ -9,7 +9,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 When effectAllowed == "uninitialized"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
 FAIL event.dataTransfer.dropEffect should be copy. Was none.
 FAIL event.dataTransfer.dropEffect should be move. Was none.
 FAIL event.dataTransfer.dropEffect should be link. Was none.
@@ -17,7 +17,7 @@ PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "none"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
@@ -25,63 +25,63 @@ PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "all"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "copy"
+PASS event.dataTransfer.dropEffect is "move"
+PASS event.dataTransfer.dropEffect is "link"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "copy"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "copy"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "move"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
 PASS event.dataTransfer.dropEffect is "none"
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "move"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "link"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "link"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "copyMove"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "copy"
+PASS event.dataTransfer.dropEffect is "move"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "copyLink"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
 PASS event.dataTransfer.dropEffect is "none"
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "copy"
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "link"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "linkMove"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
 PASS event.dataTransfer.dropEffect is "none"
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
+PASS event.dataTransfer.dropEffect is "move"
+PASS event.dataTransfer.dropEffect is "link"
 PASS event.dataTransfer.dropEffect is "none"
 
 When effectAllowed == "dummy"
 
-PASS event.dataTransfer.dropEffect is dropEffectElem.options[dropEffectElem.selectedIndex].value
+PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"
 PASS event.dataTransfer.dropEffect is "none"

diff --git a/LayoutTests/fast/events/drag-and-drop.html b/LayoutTests/fast/events/drag-and-drop.html
index 54d29bce058efb72d9e0be6b18ba42b9e052fe90..3e4342779a59f8b8533e42cccf601d89ee276f00 100644 (file)
--- a/LayoutTests/fast/events/drag-and-drop.html
+++ b/LayoutTests/fast/events/drag-and-drop.html
@@ -89,7 +89,7 @@
         var actualDropEffect = e.dataTransfer.dropEffect;
         
         if (isDropEffectAllowed(chosenDropEffect, chosenEffectAllowed))
-            shouldEvaluateTo('event.dataTransfer.dropEffect', 'dropEffectElem.options[dropEffectElem.selectedIndex].value');
+            shouldBeEqualToString('event.dataTransfer.dropEffect', dropEffectElem.options[dropEffectElem.selectedIndex].value);
         else
             shouldBeEqualToString('event.dataTransfer.dropEffect', 'none');