Reviewed by John.
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Aug 2004 03:26:06 +0000 (03:26 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Aug 2004 03:26:06 +0000 (03:26 +0000)
- fixed <rdar://problem/3549369> Crash at www.e1.ru in HTMLTokenizer::notifyFinished

Probably also fixed the following likely duplicates:

<rdar://problem/3503938> Safari crashed opening many tabs (HTMLTokenizer::notifyFinished(khtml::CachedObject*))
<rdar://problem/3566332> CrashTracer: ..405 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
<rdar://problem/3703964> CrashTracer: ...86 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
<rdar://problem/3703969> CrashTracer: ..234 crashes at com.apple.WebCore: HTMLTokenizer::notifyFinished + 0x1c8

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::open): call setParsing(true), because we need to know we are once again
parsing when we re-open a document that has previously completed loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/xml/dom_docimpl.cpp

index 53401658dae0a5dffa8aee6bb850bb1d980ca630..f17a7887b114aacf40fe27014c17cf2d7e2a1db5 100644 (file)
@@ -1,3 +1,20 @@
+2004-08-19  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by John.
+
+       - fixed <rdar://problem/3549369> Crash at www.e1.ru in HTMLTokenizer::notifyFinished
+
+       Probably also fixed the following likely duplicates:
+
+       <rdar://problem/3503938> Safari crashed opening many tabs (HTMLTokenizer::notifyFinished(khtml::CachedObject*))
+       <rdar://problem/3566332> CrashTracer: ..405 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
+       <rdar://problem/3703964> CrashTracer: ...86 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
+       <rdar://problem/3703969> CrashTracer: ..234 crashes at com.apple.WebCore: HTMLTokenizer::notifyFinished + 0x1c8
+
+        * khtml/xml/dom_docimpl.cpp:
+        (DocumentImpl::open): call setParsing(true), because we need to know we are once again
+       parsing when we re-open a document that has previously completed loading.
+
 2004-08-19  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Dave and Darin.
index dd2775785bc0ac6b50c3f008a9050caac90f4c2d..59fb7c14a625a11b752afc733dc7d80a0952cd07 100644 (file)
@@ -1286,6 +1286,7 @@ void DocumentImpl::open(  )
 
     clear();
     m_tokenizer = createTokenizer();
+    setParsing(true);
     connect(m_tokenizer,SIGNAL(finishedParsing()),this,SIGNAL(finishedParsing()));
 
     if (m_view && m_view->part()->jScript()) {