https://bugs.webkit.org/show_bug.cgi?id=131268
Reviewed by Timothy Hatcher.
Source/WebCore:
This was used in the old inspector frontend tests for the Network panel.
It's no longer used by any tests or frontend code.
* WebCore.exp.in: Remove symbols.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setInspectorResourcesDataSizeLimits): Deleted.
* inspector/InspectorController.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): Deleted.
* inspector/InspectorResourceAgent.h:
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits): Deleted.
* inspector/NetworkResourcesData.h:
* testing/Internals.cpp:
(WebCore::Internals::setInspectorResourcesDataSizeLimits): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove symbols.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2014-04-05 Brian J. Burg <burg@cs.washington.edu>
+
+ Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
+ https://bugs.webkit.org/show_bug.cgi?id=131268
+
+ Reviewed by Timothy Hatcher.
+
+ This was used in the old inspector frontend tests for the Network panel.
+ It's no longer used by any tests or frontend code.
+
+ * WebCore.exp.in: Remove symbols.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::setInspectorResourcesDataSizeLimits): Deleted.
+ * inspector/InspectorController.h:
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals): Deleted.
+ * inspector/InspectorResourceAgent.h:
+ * inspector/NetworkResourcesData.cpp:
+ (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): Deleted.
+ * inspector/NetworkResourcesData.h:
+ * testing/Internals.cpp:
+ (WebCore::Internals::setInspectorResourcesDataSizeLimits): Deleted.
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
2014-04-05 Alexey Proskuryakov <ap@apple.com>
REGRESSION (NetworkProcess): Subresources fail to load from AppCache
__ZN7WebCore19InspectorController18setProfilerEnabledEb
__ZN7WebCore19InspectorController25evaluateForTestInFrontendERKN3WTF6StringE
__ZN7WebCore19InspectorController26setInspectorFrontendClientENSt3__110unique_ptrINS_23InspectorFrontendClientENS1_14default_deleteIS3_EEEE
-__ZN7WebCore19InspectorController39setResourcesDataSizeLimitsFromInternalsEii
__ZN7WebCore19InspectorController4showEv
__ZN7WebCore19InspectorController5closeEv
__ZN7WebCore22instrumentationForPageEPNS_4PageE
}
}
-void InspectorController::setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize)
-{
- m_resourceAgent->setResourcesDataSizeLimitsFromInternals(maximumResourcesContentSize, maximumSingleResourceContentSize);
-}
-
bool InspectorController::developerExtrasEnabled() const
{
return m_page.settings().developerExtrasEnabled();
void resume();
- void setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize);
-
InspectorClient* inspectorClient() const { return m_inspectorClient; }
InspectorPageAgent* pageAgent() const { return m_pageAgent; }
#endif // ENABLE(WEB_SOCKETS)
-// called from Internals for layout test purposes.
-void InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize)
-{
- m_resourcesData->setResourcesDataSizeLimits(maximumResourcesContentSize, maximumSingleResourceContentSize);
-}
-
void InspectorResourceAgent::enable(ErrorString*)
{
enable();
void didReceiveWebSocketFrameError(unsigned long identifier, const String&);
#endif
- // Called from Internals for layout test purposes.
- void setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize);
-
// Called from frontend.
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
m_reusedXHRReplayDataRequestIds.clear();
}
-void NetworkResourcesData::setResourcesDataSizeLimits(size_t maximumResourcesContentSize, size_t maximumSingleResourceContentSize)
-{
- clear();
- m_maximumResourcesContentSize = maximumResourcesContentSize;
- m_maximumSingleResourceContentSize = maximumSingleResourceContentSize;
-}
-
NetworkResourcesData::ResourceData* NetworkResourcesData::resourceDataForRequestId(const String& requestId)
{
if (requestId.isNull())
Vector<String> removeCachedResource(CachedResource*);
void clear(const String& preservedLoaderId = String());
- void setResourcesDataSizeLimits(size_t maximumResourcesContentSize, size_t maximumSingleResourceContentSize);
void setXHRReplayData(const String& requestId, XHRReplayData*);
void reuseXHRReplayData(const String& requestId, const String& reusedRequestId);
XHRReplayData* xhrReplayData(const String& requestId);
m_frontendWindow.release();
}
-void Internals::setInspectorResourcesDataSizeLimits(int maximumResourcesContentSize, int maximumSingleResourceContentSize, ExceptionCode& ec)
-{
- Page* page = contextDocument()->frame()->page();
- if (!page) {
- ec = INVALID_ACCESS_ERR;
- return;
- }
- page->inspectorController().setResourcesDataSizeLimitsFromInternals(maximumResourcesContentSize, maximumSingleResourceContentSize);
-}
-
void Internals::setJavaScriptProfilingEnabled(bool enabled, ExceptionCode& ec)
{
Page* page = contextDocument()->frame()->page();
Vector<String> consoleMessageArgumentCounts() const;
PassRefPtr<DOMWindow> openDummyInspectorFrontend(const String& url);
void closeDummyInspectorFrontend();
- void setInspectorResourcesDataSizeLimits(int maximumResourcesContentSize, int maximumSingleResourceContentSize, ExceptionCode&);
void setJavaScriptProfilingEnabled(bool enabled, ExceptionCode&);
void setInspectorIsUnderTest(bool isUnderTest, ExceptionCode&);
#endif
[Conditional=INSPECTOR] sequence<DOMString> consoleMessageArgumentCounts();
[Conditional=INSPECTOR] DOMWindow openDummyInspectorFrontend(DOMString url);
[Conditional=INSPECTOR] void closeDummyInspectorFrontend();
- [Conditional=INSPECTOR, RaisesException] void setInspectorResourcesDataSizeLimits(long maximumResourcesContentSize, long maximumSingleResourceContentSize);
[Conditional=INSPECTOR, RaisesException] void setJavaScriptProfilingEnabled(boolean creates);
[Conditional=INSPECTOR, RaisesException] void setInspectorIsUnderTest(boolean isUnderTest);
+2014-04-05 Brian J. Burg <burg@cs.washington.edu>
+
+ Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
+ https://bugs.webkit.org/show_bug.cgi?id=131268
+
+ Reviewed by Timothy Hatcher.
+
+ * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove symbols.
+
2014-04-05 Brian J. Burg <burg@cs.washington.edu>
Web Inspector: remove unused metrics and commands from the Timeline agent
symbolWithPointer(?setInspectorFrontendClient@InspectorController@WebCore@@QAEXV?$unique_ptr@VInspectorFrontendClient@WebCore@@U?$default_delete@VInspectorFrontendClient@WebCore@@@std@@@std@@@Z, ?setInspectorFrontendClient@InspectorController@WebCore@@QEAAXV?$unique_ptr@VInspectorFrontendClient@WebCore@@U?$default_delete@VInspectorFrontendClient@WebCore@@@std@@@std@@@Z)
symbolWithPointer(?setProperty@Settings@InspectorFrontendClientLocal@WebCore@@UAEXABVString@WTF@@0@Z, ?setProperty@Settings@InspectorFrontendClientLocal@WebCore@@UEAAXAEBVString@WTF@@0@Z)
symbolWithPointer(?windowObjectCleared@InspectorFrontendClientLocal@WebCore@@UAEXXZ, ?windowObjectCleared@InspectorFrontendClientLocal@WebCore@@UEAAXXZ)
- symbolWithPointer(?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z, ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QEAAXHH@Z)
symbolWithPointer(?pathByAppendingComponent@WebCore@@YA?AVString@WTF@@ABV23@0@Z, ?pathByAppendingComponent@WebCore@@YA?AVString@WTF@@AEBV23@0@Z)
symbolWithPointer(?setProfilerEnabled@InspectorController@WebCore@@QAEX_N@Z, ?setProfilerEnabled@InspectorController@WebCore@@QEAAX_N@Z)
symbolWithPointer(?disconnectFrontend@InspectorController@WebCore@@QAEXW4InspectorDisconnectReason@Inspector@@@Z, ?disconnectFrontend@InspectorController@WebCore@@QEAAXW4InspectorDisconnectReason@Inspector@@@Z)