Dashboard cleanup: remove dashboard time logging.
authorjparent@chromium.org <jparent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 21:00:54 +0000 (21:00 +0000)
committerjparent@chromium.org <jparent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 21:00:54 +0000 (21:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=111608

Reviewed by Dirk Pranke.

Remove logTime.  It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestResultServer/static-dashboards/dashboard_base.js
Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

index f18f6656b0e06e42ac44b5c0afc0995622a2709e..fd405237516bdd5a5a251405e3dd6241bdb608ba 100644 (file)
@@ -1,3 +1,19 @@
+2013-03-06  Julie Parent  <jparent@chromium.org>
+
+        Dashboard cleanup: remove dashboard time logging.
+        https://bugs.webkit.org/show_bug.cgi?id=111608
+
+        Reviewed by Dirk Pranke.
+
+        Remove logTime.  It was never accurate, and the dev tools
+        have better ways to measure this if anyone cares to look
+        into dashboard perf.
+        
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (processTestRunsForBuilder):
+        (appendHTML):
+
 2013-03-06  Tony Chang  <tony@chromium.org>
 
         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
 2013-03-06  Tony Chang  <tony@chromium.org>
 
         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
index c5ab1e39054bdededb4fa9ae523428b457501c05..4fc13f3163bc61f3bc2c74f1e7d11916330675d9 100644 (file)
@@ -32,7 +32,6 @@
 //
 // The calling page is expected to implement the following "abstract"
 // functions/objects:
 //
 // The calling page is expected to implement the following "abstract"
 // functions/objects:
-var g_pageLoadStartTime = Date.now();
 var g_resourceLoader;
 
 // Generates the contents of the dashboard. The page should override this with
 var g_resourceLoader;
 
 // Generates the contents of the dashboard. The page should override this with
@@ -549,11 +548,6 @@ function joinParameters(stateObject)
     return state.join('&');
 }
 
     return state.join('&');
 }
 
-function logTime(msg, startTime)
-{
-    console.log(msg + ': ' + (Date.now() - startTime));
-}
-
 function hidePopup()
 {
     var popup = $('popup');
 function hidePopup()
 {
     var popup = $('popup');
@@ -845,9 +839,6 @@ document.addEventListener('mousedown', function(e) {
 }, false);
 
 window.addEventListener('load', function() {
 }, false);
 
 window.addEventListener('load', function() {
-    // This doesn't seem totally accurate as there is a race between
-    // onload firing and the last script tag being executed.
-    logTime('Time to load JS', g_pageLoadStartTime);
     g_resourceLoader = new loader.Loader();
     g_resourceLoader.load();
 }, false);
     g_resourceLoader = new loader.Loader();
     g_resourceLoader.load();
 }, false);
index 0eb61241a7b979d7ca164fb066b12ccccf7b41f6..ab4899b8a6073396a8e03aa5d9f2a5a1a3c220ae 100644 (file)
@@ -942,8 +942,7 @@ function processTestRunsForBuilder(builderName)
     }
 
     processExpectations();
     }
 
     processExpectations();
-    var start = Date.now();
-
+   
     var buildInfo = platformAndBuildType(builderName);
     var platform = buildInfo.platform;
     var buildType = buildInfo.buildType;
     var buildInfo = platformAndBuildType(builderName);
     var platform = buildInfo.platform;
     var buildType = buildInfo.buildType;
@@ -996,7 +995,6 @@ function processTestRunsForBuilder(builderName)
     }
 
     g_perBuilderFailures[builderName] = failures;
     }
 
     g_perBuilderFailures[builderName] = failures;
-    logTime('processTestRunsForBuilder: ' + builderName, start);
 }
 
 function processMissingAndExtraExpectations(resultsForTest)
 }
 
 function processMissingAndExtraExpectations(resultsForTest)
@@ -1469,13 +1467,11 @@ function htmlForTestTable(rowsHTML, opt_excludeHeaders)
 
 function appendHTML(html)
 {
 
 function appendHTML(html)
 {
-    var startTime = Date.now();
     // InnerHTML to a div that's not in the document. This is
     // ~300ms faster in Safari 4 and Chrome 4 on mac.
     var div = document.createElement('div');
     div.innerHTML = html;
     document.body.appendChild(div);
     // InnerHTML to a div that's not in the document. This is
     // ~300ms faster in Safari 4 and Chrome 4 on mac.
     var div = document.createElement('div');
     div.innerHTML = html;
     document.body.appendChild(div);
-    logTime('Time to innerHTML', startTime);
     postHeightChangedMessage();
 }
 
     postHeightChangedMessage();
 }