Reviewed by Adam.
authoraliceli1 <aliceli1@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Oct 2006 03:57:08 +0000 (03:57 +0000)
committeraliceli1 <aliceli1@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Oct 2006 03:57:08 +0000 (03:57 +0000)
        Fixed <rdar://problem/4731778>

        * editing/CommandByName.cpp:
        (WebCore::Frame::Command::):
        was calling the wrong enabledFn for arrow selection and navigation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/editing/CommandByName.cpp

index 9fee83b419f973ff7f1fff7ede88d70fabdbff6e..8fb70c80e883e4bb2efc67a934d88f201940401f 100644 (file)
@@ -1,3 +1,13 @@
+2006-10-05  Alice  <alice.liu@apple.com>
+
+        Reviewed by Adam.
+
+        Fixed <rdar://problem/4731778>
+
+        * editing/CommandByName.cpp:
+        (WebCore::Frame::Command::):
+        was calling the wrong enabledFn for arrow selection and navigation
+
 2006-10-05  Adele Peterson  <adele@apple.com>
 
         Reviewed by Maciej.
index 4496d3c9b8eb2ee5f41c7533df75dabf218e19b6..2b79320c49d5d7228542e55cbfeb18e1bb027fdd 100644 (file)
@@ -192,15 +192,14 @@ CommandMap* createCommandDictionary()
         { "ForwardDelete", { execForwardDelete, enabledAnyEditableSelection } },
         { "Paste", { execPaste, enabledPaste } },
         { "SelectAll", { execSelectAll, enabled } },
-        // FIXME: not sure if the following 8 should be enabledAnyRangeSelection or enabledAnySelection
-        { "MoveLeft", { execMoveLeft, enabledAnyRangeSelection } },
-        { "MoveRight", { execMoveRight, enabledAnyRangeSelection } },
-        { "MoveUp", { execMoveUp, enabledAnyRangeSelection } },
-        { "MoveDown", { execMoveDown, enabledAnyRangeSelection } },
-        { "SelectLeft", { execSelectLeft, enabledAnyRangeSelection } },
-        { "SelectRight", { execSelectRight, enabledAnyRangeSelection } },
-        { "SelectUp", { execSelectUp, enabledAnyRangeSelection } },
-        { "SelectDown", { execSelectDown, enabledAnyRangeSelection } }
+        { "MoveLeft", { execMoveLeft, enabledAnySelection } },
+        { "MoveRight", { execMoveRight, enabledAnySelection } },
+        { "MoveUp", { execMoveUp, enabledAnySelection } },
+        { "MoveDown", { execMoveDown, enabledAnySelection } },
+        { "SelectLeft", { execSelectLeft, enabledAnySelection } },
+        { "SelectRight", { execSelectRight, enabledAnySelection } },
+        { "SelectUp", { execSelectUp, enabledAnySelection } },
+        { "SelectDown", { execSelectDown, enabledAnySelection } }
     };
 
     CommandMap* commandMap = new CommandMap;