Reviewed by John.

	- fix recent regression from collection perf fixes.

        * khtml/html/html_miscimpl.cpp:
        (HTMLFormCollectionImpl::updateNameCache): Look up the name
	attribute in the name cache, not the id cache (d'oh!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 6de392ef408405a4b2bc79b4f476bceaabb5b7b7..41733d9b90c7ff999680e882d3ad373061ec0a6b 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,13 @@
+2004-11-30  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by John.
+
+       - fix recent regression from collection perf fixes.
+       
+        * khtml/html/html_miscimpl.cpp:
+        (HTMLFormCollectionImpl::updateNameCache): Look up the name
+       attribute in the name cache, not the id cache (d'oh!)
+
 2004-11-30  Darin Adler  <darin@apple.com>
 
         Reviewed by Ken.

diff --git a/WebCore/khtml/html/html_miscimpl.cpp b/WebCore/khtml/html/html_miscimpl.cpp
index 917910e504974b3a9c746d6584ea03ae8f56a24f..6815f25ffd41166abd0f89800f43866ad5640f98 100644 (file)
--- a/WebCore/khtml/html/html_miscimpl.cpp
+++ b/WebCore/khtml/html/html_miscimpl.cpp
@@ -630,7 +630,7 @@ void HTMLFormCollectionImpl::updateNameCache() const
             }
             if (!nameAttr.isEmpty() && idAttr != nameAttr) {
                 // add to name cache
-                QPtrVector<NodeImpl> *nameVector = info->idCache.find(nameAttr);
+                QPtrVector<NodeImpl> *nameVector = info->nameCache.find(nameAttr);
                 if (!nameVector) {
                     nameVector = new QPtrVector<NodeImpl>;
                     info->nameCache.insert(nameAttr, nameVector);