JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Feb 2013 06:04:12 +0000 (06:04 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Feb 2013 06:04:12 +0000 (06:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109542

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

Source/WebCore:

"JSGenerateToJSObject" should be included in IDL files
of ChannelSplitterNode and ChannelMergerNode in WebAudio.
This ensures html files to access corresponding objects.

* Modules/webaudio/ChannelMergerNode.idl:
* Modules/webaudio/ChannelSplitterNode.idl:

LayoutTests:

Test cases updated to check validity of ChannelSplitterNode
and ChannelMergerNode Objects.

* webaudio/audiochannelmerger-basic-expected.txt:
* webaudio/audiochannelmerger-basic.html:
* webaudio/audiochannelsplitter-expected.txt:
* webaudio/audiochannelsplitter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/webaudio/audiochannelmerger-basic-expected.txt
LayoutTests/webaudio/audiochannelmerger-basic.html
LayoutTests/webaudio/audiochannelsplitter-expected.txt
LayoutTests/webaudio/audiochannelsplitter.html
Source/WebCore/ChangeLog
Source/WebCore/Modules/webaudio/ChannelMergerNode.idl
Source/WebCore/Modules/webaudio/ChannelSplitterNode.idl

index 7520de9a5498fc2b4352aed20ef2b163fdd70578..ea24b1cade1ff47fb627b7fd7bcc9fb85841a50a 100644 (file)
@@ -1,3 +1,18 @@
+2013-02-13  Praveen R Jadhav  <praveen.j@samsung.com>
+
+        JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
+        https://bugs.webkit.org/show_bug.cgi?id=109542
+
+        Reviewed by Kentaro Hara.
+
+        Test cases updated to check validity of ChannelSplitterNode
+        and ChannelMergerNode Objects.
+
+        * webaudio/audiochannelmerger-basic-expected.txt:
+        * webaudio/audiochannelmerger-basic.html:
+        * webaudio/audiochannelsplitter-expected.txt:
+        * webaudio/audiochannelsplitter.html:
+
 2013-02-12  Gregg Tavares  <gman@chromium.org>
 
         Adds failing WebGL Conformance Tests.
index 5a6a16da7be993d5462ca746627f209275584ff3..e71ed17fae3fb0f0a2134f103bca66238dc2ca80 100644 (file)
@@ -6,6 +6,7 @@ PASS Exception was thrown for numberOfInputs <= 0.
 PASS Exception was thrown for numberOfInputs >= 32.
 PASS AudioChannelMerger created successfully with numberOfInputs = 32.
 PASS AudioChannelMerger created successfully with empty parameter.
+PASS ChannelMergerNode Object is available.
 PASS successfullyParsed is true
 
 TEST COMPLETE
index f66c5670d7d1bea9f1656fdf5d8f1a4daff11d56..50d39b2e169f0bc5ddc3acfc9cc7820fc944daab 100644 (file)
@@ -48,6 +48,10 @@ function runTest() {
     try {
         var mergernode = context.createChannelMerger();
         testPassed("AudioChannelMerger created successfully with empty parameter.");
+        if (mergernode.toString().indexOf("ChannelMergerNode") > -1)
+            testPassed("ChannelMergerNode Object is available.");
+        else
+            testFailed("ChannelMergerNode Object is not available.");
     } catch(e) {
         testFailed("Failed to create AudioChannelMerger with empty parameter.");
     }
index 388aba055d7bebe01bee006fd2ee36adc3879cd2..2ad4a370667409fa9db31a7d59b022281c1bbcf1 100644 (file)
@@ -9,6 +9,7 @@ PASS AudioChannelSplitter has 32 outputs when it is created with numberOfOutputs
 PASS AudioChannelSplitter has one input.
 PASS AudioChannelSplitter created successfully with empty parameter.
 PASS AudioChannelSplitter has 6 outputs when it is created with empty parameter.
+PASS ChannelSplitterNode Object is available.
 PASS Correctly exchanged left and right channels.
 PASS successfullyParsed is true
 
index c7a5143ea3d8618421d3a10385275455ed3edb68..6bebc5b28b6a2afb02d33fb221141b0d56f7d419 100644 (file)
@@ -120,6 +120,11 @@ function runTest() {
             testPassed("AudioChannelSplitter has 6 outputs when it is created with empty parameter.");
         else
             testFailed("AudioChannelSplitter should have 6 outputs when it is created with empty parameter.");
+
+        if (splitternode.toString().indexOf("ChannelSplitterNode") > -1)
+            testPassed("ChannelSplitterNode Object is available.");
+        else
+            testFailed("ChannelSplitterNode Object is not available.");
     } catch(e) {
         testFailed("Failed to create AudioChannelSplitter with empty parameter.");
     }
index b183a57742e0ed95703cb591c5d743d413051e67..b0d969995580a9fd7e3d04bf765fd5bf51adbc64 100644 (file)
@@ -1,3 +1,17 @@
+2013-02-13  Praveen R Jadhav  <praveen.j@samsung.com>
+
+        JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
+        https://bugs.webkit.org/show_bug.cgi?id=109542
+
+        Reviewed by Kentaro Hara.
+
+        "JSGenerateToJSObject" should be included in IDL files
+        of ChannelSplitterNode and ChannelMergerNode in WebAudio.
+        This ensures html files to access corresponding objects.
+
+        * Modules/webaudio/ChannelMergerNode.idl:
+        * Modules/webaudio/ChannelSplitterNode.idl:
+
 2013-02-13   Vineet Chaudhary  <rgf748@motorola.com>
 
         [Regression] After r142831  collection-null-like-arguments.html layout test failing
index e79ce5a2d59e58b372330cc059350c01eeed6514..8158d7c22782d4981fea82d11eb58fc07f7f46cb 100644 (file)
@@ -27,6 +27,7 @@
  */
 
 [
-    Conditional=WEB_AUDIO
+    Conditional=WEB_AUDIO,
+    JSGenerateToJSObject
 ] interface ChannelMergerNode : AudioNode {
 };
index eabfba1ef96d813e9af5905da594e1da8be90bfd..6bbf0bbf78e6dd61e78423172767068d7ae58581 100644 (file)
@@ -23,6 +23,7 @@
  */
 
 [
-    Conditional=WEB_AUDIO
+    Conditional=WEB_AUDIO,
+    JSGenerateToJSObject
 ] interface ChannelSplitterNode : AudioNode {
 };