[EFL] Enable view mode media feature layout tests
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 20:43:12 +0000 (20:43 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 20:43:12 +0000 (20:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=81205

Tools:

Adding missing implementation setViewModeMediaFeature to EFL's
LayoutTestController so that we can unskip view mode
media feature layout tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setViewModeMediaFeature): Implemented.

LayoutTests:

Unskip tests connected with setViewModeMediaFeature.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl/Skipped
Tools/ChangeLog
Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

index 275a299..657e3f4 100644 (file)
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] Enable view mode media feature layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=81205
+
+        Unskip tests connected with setViewModeMediaFeature.
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped:
+
 2012-03-22  Dan Bernstein  <mitz@apple.com>
 
         Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2
index 95582c7..8861c9d 100644 (file)
@@ -429,15 +429,6 @@ svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html
 svg/custom/manually-parsed-svg-disallowed-in-dashboard.html
 svg/custom/svg-disallowed-in-dashboard-object.html
 
-# EFL's LayoutTestController does not implement setViewModeMediaFeature
-fast/media/media-query-list-02.html
-fast/media/media-query-list-03.html
-fast/media/media-query-list-04.html
-fast/media/media-query-list-05.html
-fast/media/media-query-list-06.html
-fast/media/media-query-list-07.html
-fast/media/view-mode-media-feature.html
-
 # EFL's LayoutTestController does not implement enableAutoResizeMode
 fast/autoresize
 
index 651f66c..655b7fc 100644 (file)
@@ -1,3 +1,17 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] Enable view mode media feature layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=81205
+
+        Adding missing implementation setViewModeMediaFeature to EFL's 
+        LayoutTestController so that we can unskip view mode 
+        media feature layout tests.
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setViewModeMediaFeature): Implemented.
+
 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
 
         nrwt: crash while stopping layout test helper on apple mac lion
index b2a41df..a7c8812 100644 (file)
@@ -263,9 +263,22 @@ void LayoutTestController::setValueForUser(JSContextRef context, JSValueRef node
     DumpRenderTreeSupportEfl::setValueForUser(context, nodeObject, value);
 }
 
-void LayoutTestController::setViewModeMediaFeature(JSStringRef)
+void LayoutTestController::setViewModeMediaFeature(JSStringRef mode)
 {
-    notImplemented();
+    Evas_Object* view = browser->mainView();
+    if (!view)
+        return;
+
+    if (equals(mode, "windowed"))
+        ewk_view_mode_set(view, EWK_VIEW_MODE_WINDOWED);
+    else if (equals(mode, "floating"))
+        ewk_view_mode_set(view, EWK_VIEW_MODE_FLOATING);
+    else if (equals(mode, "fullscreen"))
+        ewk_view_mode_set(view, EWK_VIEW_MODE_FULLSCREEN);
+    else if (equals(mode, "maximized"))
+        ewk_view_mode_set(view, EWK_VIEW_MODE_MAXIMIZED);
+    else if (equals(mode, "minimized"))
+        ewk_view_mode_set(view, EWK_VIEW_MODE_MINIMIZED);
 }
 
 void LayoutTestController::setWindowIsKey(bool)