https://bugs.webkit.org/show_bug.cgi?id=64465
Reviewed by Dmitry Titov.
There isn't a good way to test this as it is very highly unlikely to occur.
Source/JavaScriptCore:
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
isn't thread-safe, change the initialization to be global.
Source/WebKit2:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::shouldCallRealDebugger): :Since scoped static initialization
isn't thread-safe, change the initialization to be global.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-07-13 David Levin <levin@chromium.org>
+
+ Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
+ https://bugs.webkit.org/show_bug.cgi?id=64465
+
+ Reviewed by Dmitry Titov.
+
+ There isn't a good way to test this as it is very highly unlikely to occur.
+
+ * wtf/ThreadIdentifierDataPthreads.cpp:
+ (WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
+ isn't thread-safe, change the initialization to be global.
+
2011-07-12 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64424
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
namespace WTF {
pthread_key_t ThreadIdentifierData::m_key;
+static pthread_once_t onceControl = PTHREAD_ONCE_INIT;
void clearPthreadHandleForIdentifier(ThreadIdentifier);
void ThreadIdentifierData::initializeKeyOnce()
{
- static pthread_once_t onceControl = PTHREAD_ONCE_INIT;
if (pthread_once(&onceControl, initializeKeyOnceHelper))
CRASH();
}
+2011-07-13 David Levin <levin@chromium.org>
+
+ Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
+ https://bugs.webkit.org/show_bug.cgi?id=64465
+
+ Reviewed by Dmitry Titov.
+
+ There isn't a good way to test this as it is very highly unlikely to occur.
+
+ * PluginProcess/mac/PluginProcessMac.mm:
+ (WebKit::shouldCallRealDebugger): :Since scoped static initialization
+ isn't thread-safe, change the initialization to be global.
+
2011-07-13 Andreas Kling <kling@webkit.org>
[Qt][WK2] Remove invalid signal/slot connection in QTouchWebView.
/*
* Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
namespace WebKit {
+static pthread_once_t shouldCallRealDebuggerOnce = PTHREAD_ONCE_INIT;
+
class FullscreenWindowTracker {
WTF_MAKE_NONCOPYABLE(FullscreenWindowTracker);
static bool shouldCallRealDebugger()
{
- static pthread_once_t shouldCallRealDebuggerOnce = PTHREAD_ONCE_INIT;
pthread_once(&shouldCallRealDebuggerOnce, initShouldCallRealDebugger);
return isUserbreakSet;