Bug #: 4280

Submitted by: eseidel
Reviewed by: darin
        * Scripts/build-drawtest:
        * Scripts/build-dumprendertree:
        * Scripts/build-svg2png:
        * Scripts/build-webcore-svg:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm: added checkRequiredSystemConfig()
        Added checkRequiredSystemConfig and made all the build-* scripts
        use it to print a pretty warning when trying to compile on an
        unsupported system (less than 10.4, Xcode 2.1).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4280

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 66d03c43a675bfec071db2e49d50e70531b7986a..d1ab6aecfe77ee936bbe8f8c5d188a55bb420730 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,18 @@
+2005-08-04  Eric Seidel  <eseidel@apple.com>
+
+        Reviewed by darin.
+
+        * Scripts/build-drawtest:
+        * Scripts/build-dumprendertree:
+        * Scripts/build-svg2png:
+        * Scripts/build-webcore-svg:
+        * Scripts/build-webkit:
+        * Scripts/webkitdirs.pm: added checkRequiredSystemConfig()
+        Added checkRequiredSystemConfig and made all the build-* scripts
+        use it to print a pretty warning when trying to compile on an
+        unsupported system (less than 10.4, Xcode 2.1).
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=4280
+
 2005-08-04  Darin Adler  <darin@apple.com>
 
         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Bring this file back from

diff --git a/WebKitTools/Scripts/build-drawtest b/WebKitTools/Scripts/build-drawtest
index a5fcab7c6135552bf649dd8abbb2cb5436e2d302..49a4986eb4fbc81d96152e58934651bf96d4b643 100755 (executable)
--- a/WebKitTools/Scripts/build-drawtest
+++ b/WebKitTools/Scripts/build-drawtest
@@ -34,6 +34,7 @@ use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
 
+checkRequiredSystemConfig();
 setConfiguration();
 chdirWebKit();
 my @options = XcodeOptions();

diff --git a/WebKitTools/Scripts/build-dumprendertree b/WebKitTools/Scripts/build-dumprendertree
index df160499ec5b4c6f97b7a054da3ecb0a4e30da0a..5e72177cddc4a8b2c5454070202c6eacbe7acc00 100755 (executable)
--- a/WebKitTools/Scripts/build-dumprendertree
+++ b/WebKitTools/Scripts/build-dumprendertree
@@ -35,6 +35,7 @@ use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
 
+checkRequiredSystemConfig();
 setConfiguration();
 chdirWebKit();
 my @options = XcodeOptions();

diff --git a/WebKitTools/Scripts/build-svg2png b/WebKitTools/Scripts/build-svg2png
index 6419a70f6165045fcc249e606e16a20d5c5f8b87..25b42cdca59595f9bba0fce72d35aaffb7141bd7 100755 (executable)
--- a/WebKitTools/Scripts/build-svg2png
+++ b/WebKitTools/Scripts/build-svg2png
@@ -34,6 +34,7 @@ use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
 
+checkRequiredSystemConfig();
 setConfiguration();
 chdirWebKit();
 my @options = XcodeOptions();

diff --git a/WebKitTools/Scripts/build-webcore-svg b/WebKitTools/Scripts/build-webcore-svg
index cb88e27b059fc9620c1de61588b24df22892d32d..e6b06630b6143487ed8b4a18580a9a32fac4b652 100755 (executable)
--- a/WebKitTools/Scripts/build-webcore-svg
+++ b/WebKitTools/Scripts/build-webcore-svg
@@ -33,6 +33,7 @@ use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
 
+checkRequiredSystemConfig();
 setConfiguration();
 chdirWebKit();
 my $productDir = productDir();

diff --git a/WebKitTools/Scripts/build-webkit b/WebKitTools/Scripts/build-webkit
index a0a7b88403a8aaf433aab633c1b7d2093c4e37f3..1478a2ae6a56d36a09efb09a4c8933d563794ef4 100755 (executable)
--- a/WebKitTools/Scripts/build-webkit
+++ b/WebKitTools/Scripts/build-webkit
@@ -33,6 +33,7 @@ use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
 
+checkRequiredSystemConfig();
 setConfiguration();
 chdirWebKit();
 my $productDir = productDir();

diff --git a/WebKitTools/Scripts/webkitdirs.pm b/WebKitTools/Scripts/webkitdirs.pm
index 86ade837f39a7293cf0976e1d0ff56a58eeac605..00fbfc48b11db46563862316d824aa7cf5baadb9 100644 (file)
--- a/WebKitTools/Scripts/webkitdirs.pm
+++ b/WebKitTools/Scripts/webkitdirs.pm
@@ -198,4 +198,25 @@ sub checkSVGFrameworks
     }
 }
 
+sub checkRequiredSystemConfig
+{
+    chomp(my $productVersion = `sw_vers -productVersion`);
+    if ($productVersion lt "10.4") {
+        print "*************************************************************\n";
+        print "Mac OS X Version 10.4.0 or later is required to build WebKit.\n";
+        print "You have " . $productVersion . ", thus the build will most likely fail.\n";
+        print "*************************************************************\n";
+    }
+    my $xcodeVersion = `xcodebuild -version`;
+    $xcodeVersion =~ s|DevToolsCore-(.+?); .*|$1|;
+    if ($xcodeVersion < 620) {
+        print "*************************************************************\n";
+        print "Xcode Version 2.1 or later is required to build WebKit.\n";
+        print "You have an earlier version of Xcode, thus the build will\n";
+        print "most likely fail.  The latest Xcode is available from the web:\n";
+        print "http://developer.apple.com/tools/xcode\n";
+        print "*************************************************************\n";
+    }
+}
+
 1;