Rename TestFailureBugForm to FailingTestsBugForm
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Jul 2011 15:10:17 +0000 (15:10 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Jul 2011 15:10:17 +0000 (15:10 +0000)
The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Updated for renames.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
reordered <script>s to put files which others depend on for parsing first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js [moved from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js with 97% similarity]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js [moved from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js with 98% similarity]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
Tools/ChangeLog

@@ -56,7 +56,7 @@ const BugzillaConstants = {
     },
 };
 
-function TestFailureBugForm(bugzilla, trac, tester, failingBuildName, passingBuildName, failingTests) {
+function FailingTestsBugForm(bugzilla, trac, tester, failingBuildName, passingBuildName, failingTests) {
     NewBugForm.call(this, bugzilla);
 
     this._trac = trac;
@@ -82,7 +82,7 @@ function TestFailureBugForm(bugzilla, trac, tester, failingBuildName, passingBui
     this.version = BugzillaConstants.Version.Nightly;
 }
 
-TestFailureBugForm.prototype = {
+FailingTestsBugForm.prototype = {
     domElement: function() {
         var form = NewBugForm.prototype.domElement.call(this);
         form.className = 'new-bug-form';
@@ -189,4 +189,4 @@ TestFailureBugForm.prototype = {
     },
 };
 
-TestFailureBugForm.prototype.__proto__ = NewBugForm.prototype;
+FailingTestsBugForm.prototype.__proto__ = NewBugForm.prototype;
@@ -25,7 +25,7 @@
 
 (function() {
 
-module('TestFailureBugForm');
+module('FailingTestsBugForm');
 
 function MockBuilder(name) {
     this.name = name;
@@ -59,7 +59,7 @@ function createTestForm(testerName, failingBuildName, passingBuildName, failingT
         return '[RESULTS PAGE URL ' + this.name + ', ' + buildName + ']';
     }
 
-    return new TestFailureBugForm(mockBugzilla, mockTrac, mockBuilder, failingBuildName, passingBuildName, failingTests);
+    return new FailingTestsBugForm(mockBugzilla, mockTrac, mockBuilder, failingBuildName, passingBuildName, failingTests);
 }
 
 test('component and keywords are set', 2, function() {
index d306d2a..820aee5 100644 (file)
@@ -385,7 +385,7 @@ ViewController.prototype = {
             closedList.appendChildren(closedBugs.map(bugToListItem));
         });
 
-        var bugForm = new TestFailureBugForm(this._bugzilla, this._trac, tester, failingBuildName, passingBuildName, failingTests);
+        var bugForm = new FailingTestsBugForm(this._bugzilla, this._trac, tester, failingBuildName, passingBuildName, failingTests);
 
         var form = bugForm.domElement();
         result.appendChild(form);
index 23258f7..682bb07 100644 (file)
@@ -27,19 +27,20 @@ THE POSSIBILITY OF SUCH DAMAGE.
 <html>
 <head>
     <link rel="stylesheet" href="TestFailures.css"></link>
+    <script src="Utilities.js"></script>
     <script src="Bugzilla.js"></script>
+    <script src="NewBugForm.js"></script>
+    <script src="FailingTestsBugForm.js"></script>
+
     <script src="Buildbot.js"></script>
     <script src="Builder.js"></script>
     <script src="FlakyLayoutTestDetector.js"></script>
     <script src="LayoutTestHistoryAnalyzer.js"></script>
     <script src="LayoutTestResultsLoader.js"></script>
     <script src="NRWTResultsParser.js"></script>
-    <script src="NewBugForm.js"></script>
     <script src="ORWTResultsParser.js"></script>
     <script src="PersistentCache.js"></script>
-    <script src="TestFailureBugForm.js"></script>
     <script src="Trac.js"></script>
-    <script src="Utilities.js"></script>
     <script src="ViewController.js"></script>
 
     <script src="WebKitBuildbot.js"></script>
index b760b2b..27400b9 100644 (file)
@@ -29,7 +29,7 @@
 <script src="Builder.js"></script>
 <script src="Builder_unittests.js"></script>
 
-<script src="TestFailureBugForm.js"></script>
-<script src="TestFailureBugForm_unittests.js"></script>
+<script src="FailingTestsBugForm.js"></script>
+<script src="FailingTestsBugForm_unittests.js"></script>
 </body>
 </html>
index 2c6ca88..505ea2f 100644 (file)
@@ -1,3 +1,24 @@
+2011-07-15  Adam Roben  <aroben@apple.com>
+
+        Rename TestFailureBugForm to FailingTestsBugForm
+
+        The new name will match better with a forthcoming FlakyTestBugForm class.
+
+        Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
+        name
+
+        Reviewed by Daniel Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
+        Updated for renames.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
+        reordered <script>s to put files which others depend on for parsing first.
+
 2011-07-15  Adam Barth  <abarth@webkit.org>
 
         NRWT stores the Chromium revision number in full_results.json