New flakiness dashboard should support substring matching

https://bugs.webkit.org/show_bug.cgi?id=123393

Reviewed by Alexey Proskuryakov.

Addressed the use cases by
1. Always showing the candidate even when there is exactly one test matching the current value.
2. Adding all tests that match the current value upon the user pressing enter key.

* public/index.html:
(fetchManifest): Add all tests that match the current value. Confirm whether the user really
want to add all the tests when there are more than 15 tests to add.
* public/js/autocompleter.js:
(Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
(Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
exactly one test that matches the criteria so that the user can select this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/test-results/ChangeLog b/Websites/test-results/ChangeLog
index f86081beb3a6e71d764381debc04fe564ab8c201..f77b941027fd9782df29555286a06a7a38140f65 100644 (file)
--- a/Websites/test-results/ChangeLog
+++ b/Websites/test-results/ChangeLog
@@ -1,3 +1,22 @@
+2013-10-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        New flakiness dashboard should support substring matching
+        https://bugs.webkit.org/show_bug.cgi?id=123393
+
+        Reviewed by Alexey Proskuryakov.
+
+        Addressed the use cases by
+        1. Always showing the candidate even when there is exactly one test matching the current value.
+        2. Adding all tests that match the current value upon the user pressing enter key.
+
+        * public/index.html:
+        (fetchManifest): Add all tests that match the current value. Confirm whether the user really
+        want to add all the tests when there are more than 15 tests to add.
+        * public/js/autocompleter.js:
+        (Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
+        (Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
+        exactly one test that matches the criteria so that the user can select this test.
+
 2013-10-26  Ryosuke Niwa  <rniwa@webkit.org>
 
         New flakiness dashboard shouldn't treat tests with right expectations as failing

diff --git a/Websites/test-results/public/index.html b/Websites/test-results/public/index.html
index fa6b99e88ace49dbc8f80d320d0aacb55b818ee1..a52aa8f0d32f0d8e71f286075f3de016c4758d8f 100644 (file)
--- a/Websites/test-results/public/index.html
+++ b/Websites/test-results/public/index.html
@@ -518,6 +518,23 @@ fetchManifest(function (response) {
     var input = document.getElementById('testName');
     input.autocompleter = new Autocompleter(input, testNames);
 
+    input.form.onsubmit = function (event) {
+        addTests(input.value);
+        event.preventDefault();
+        return false;
+    }
+
+    function addTests(filter) {
+        var candidates = input.autocompleter.filterCandidates(filter);
+        if (candidates.length > 15) {
+            if (!confirm('Are you sure you want to add ' + candidates.length + ' tests that match this substring?'))
+                return;
+        }
+        for (var i = 0; i < candidates.length; i++)
+            TestResultsView.fetchTest(candidates[i]);
+        TestResultsView.updateLocationHash();
+    }
+
     var builderListView = document.getElementById('builderListView');
     TestResultsView._sortObjectsByName(response['builders']).forEach(function (builder) {
         builderListView.appendChild(element('option', [builder.name]));

diff --git a/Websites/test-results/public/js/autocompleter.js b/Websites/test-results/public/js/autocompleter.js
index 5708b508e7b40fe5915987da60d847d8348c9bee..92f77a526a5ab4b485538fab311dd4b453f09db0 100644 (file)
--- a/Websites/test-results/public/js/autocompleter.js
+++ b/Websites/test-results/public/js/autocompleter.js
@@ -12,6 +12,10 @@ function Autocompleter(inputElement, list) {
     inputElement.addEventListener('keydown', this.navigate.bind(this));
 }
 
+Autocompleter.prototype.filterCandidates = function (filter) {
+    return this._list.filter(function (testName) { return testName.indexOf(filter) >= 0; });
+}
+
 Autocompleter.prototype._ensureCandidateWindow = function () {
     if (this._candidateWindow)
         return;
@@ -28,8 +32,8 @@ Autocompleter.prototype._updateCandidates = function (filter) {
     if (this._currentFilter == filter)
         return false;
 
-    var candidates = this._list.filter(function (testName) { return testName.indexOf(filter) >= 0; });
-    if (candidates.length > 50 || candidates.length == 1)
+    var candidates = this.filterCandidates(filter);
+    if (candidates.length > 50)
         candidates = [];
     this._candidates = candidates;
     this._currentFilter = filter;