Reviewed by Richard
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Sep 2004 00:05:57 +0000 (00:05 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Sep 2004 00:05:57 +0000 (00:05 +0000)
        * khtml/xml/dom_position.cpp:
        (DOM::Position::inRenderedContent): Make the "empty block" check the same as the one
        use in visible position. This fixes a recent regression which broke up and down
        arrowing between blocks with an empty block in between.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/xml/dom_position.cpp

index 7ec7786a23f8d742df9518cd612d11b8142304cd..36847fce5d58fb1e51a7d87717f4fa6dd3749d46 100644 (file)
@@ -1,3 +1,12 @@
+2004-09-23  Ken Kocienda  <kocienda@apple.com>
+
+        Reviewed by Richard
+
+        * khtml/xml/dom_position.cpp:
+        (DOM::Position::inRenderedContent): Make the "empty block" check the same as the one
+        use in visible position. This fixes a recent regression which broke up and down
+        arrowing between blocks with an empty block in between.
+
 2004-09-23  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin.
index 9674b397089a6a748c7799b1e8d1989bbad14b41..bfbffd5beb1dc530ed46b5e93fcc6b55b40862d5 100644 (file)
@@ -608,7 +608,7 @@ bool Position::inRenderedContent() const
         // and for blocks if they are empty
         if (renderer->isReplaced() ||
             (renderer->isInlineFlow() && static_cast<RenderFlow *>(renderer)->firstLineBox()) ||
-            (node()->isBlockFlow() && !node()->firstChild()))
+            (renderer->isBlockFlow() && !renderer->firstChild() && renderer->height()))
             return true;
     }