Reviewed by Darin.
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Apr 2007 07:15:08 +0000 (07:15 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Apr 2007 07:15:08 +0000 (07:15 +0000)
        - fix some test failures

        * bindings/runtime_method.cpp:
        (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl,
        otherwise this is too big
        (RuntimeMethod::getOwnPropertySlot):
        * bindings/runtime_method.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore/ChangeLog
JavaScriptCore/bindings/runtime_method.cpp
JavaScriptCore/bindings/runtime_method.h

index 54c3fa606c9957aa32d0a9bf77a06b9cab8f0e06..9e6903edcd9a9b3e776afc31772fb66bda8e4be7 100644 (file)
@@ -1,3 +1,15 @@
+2007-04-23  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Darin.
+        
+        - fix some test failures
+
+        * bindings/runtime_method.cpp:
+        (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl,
+        otherwise this is too big
+        (RuntimeMethod::getOwnPropertySlot):
+        * bindings/runtime_method.h:
+
 2007-04-22  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin.
 2007-04-22  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin.
index f46485e57cf670fd3fffab589f522775b61af86b..03a58999aaec5e1b88588cdf5c7d0c88c369c5d9 100644 (file)
 
 #include "context.h"
 #include "runtime_object.h"
 
 #include "context.h"
 #include "runtime_object.h"
+#include "function_object.h"
 
 using namespace KJS::Bindings;
 using namespace KJS;
 
 
 using namespace KJS::Bindings;
 using namespace KJS;
 
-// FIXME: this should probably use InternalFunctionImp, not FunctionImp
 RuntimeMethod::RuntimeMethod(ExecState *exec, const Identifier &ident, Bindings::MethodList &m) 
 RuntimeMethod::RuntimeMethod(ExecState *exec, const Identifier &ident, Bindings::MethodList &m) 
-    : FunctionImp (exec, ident, 0)
+    : InternalFunctionImp (static_cast<FunctionPrototype*>(exec->lexicalInterpreter()->builtinFunctionPrototype()), ident)
 {
     _methodList = m;
 }
 {
     _methodList = m;
 }
@@ -63,7 +63,7 @@ bool RuntimeMethod::getOwnPropertySlot(ExecState* exec, const Identifier& proper
         return true;
     }
     
         return true;
     }
     
-    return FunctionImp::getOwnPropertySlot(exec, propertyName, slot);
+    return InternalFunctionImp::getOwnPropertySlot(exec, propertyName, slot);
 }
 
 JSValue *RuntimeMethod::callAsFunction(ExecState *exec, JSObject *thisObj, const List &args)
 }
 
 JSValue *RuntimeMethod::callAsFunction(ExecState *exec, JSObject *thisObj, const List &args)
index e3bad0297c9724b437d3f4534a9b4d240235b7e9..7d59383a620e49526236ec8cbb258f630fbafa4c 100644 (file)
@@ -33,7 +33,7 @@
 namespace KJS {
 
 
 namespace KJS {
 
 
-class RuntimeMethod : public FunctionImp 
+class RuntimeMethod : public InternalFunctionImp 
 {
 public:
     RuntimeMethod(ExecState *exec, const Identifier &n, Bindings::MethodList &methodList);
 {
 public:
     RuntimeMethod(ExecState *exec, const Identifier &n, Bindings::MethodList &methodList);