Reviewed by Vicki.

        - fixed <rdar://problem/3901109> REGRESSION (171-172): repro crash in DOM::NodeImpl::setChanged at chick-fil-a.com

        * khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl):
        Added missing initialization for base class and node pointer.

        - fixed a few places that could leave dangling node pointers

        * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl):
        Clear out the node pointer when the node is destroyed.
        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::~HTMLElementImpl): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index d47db35d35bd935b442bf3d1ea15d0c4cc36b2b3..794d646d24347c9449329a7682d7c1428c987b5e 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,18 @@
+2004-12-03  Darin Adler  <darin@apple.com>
+
+        Reviewed by Vicki.
+
+        - fixed <rdar://problem/3901109> REGRESSION (171-172): repro crash in DOM::NodeImpl::setChanged at chick-fil-a.com
+
+        * khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl):
+        Added missing initialization for base class and node pointer.
+
+        - fixed a few places that could leave dangling node pointers
+
+        * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl):
+        Clear out the node pointer when the node is destroyed.
+        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::~HTMLElementImpl): Ditto.
+
 2004-12-03  Chris Blumenberg  <cblu@apple.com>
 
        Fix for performance regression. My original patch added a signal for passing the data of a resource to its WebCore cache object. This patch passes the data with the preexisting "finished" symbol so we make less calls. 

diff --git a/WebCore/khtml/css/css_valueimpl.cpp b/WebCore/khtml/css/css_valueimpl.cpp
index bdd324adc23ee5133070baf9ac0b27c6bbc5ed84..92f2e9d4308d93b5b11f9396e06d404b25c07686 100644 (file)
--- a/WebCore/khtml/css/css_valueimpl.cpp
+++ b/WebCore/khtml/css/css_valueimpl.cpp
@@ -80,6 +80,7 @@ CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl(CSSRuleImpl *pare
 }
 
 CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl(CSSRuleImpl *parent, const CSSProperty * const *properties, int numProperties)
+    : CSSStyleDeclarationImpl(parent), m_node(0)
 {
     for (int i = 0; i < numProperties; ++i)
         m_values.append(*properties[i]);

diff --git a/WebCore/khtml/html/html_baseimpl.cpp b/WebCore/khtml/html/html_baseimpl.cpp
index 0c06599548961eb621f7622677433d4d661c1a72..05157001609fe7ba15b7a8c8ade3de42cc102327 100644 (file)
--- a/WebCore/khtml/html/html_baseimpl.cpp
+++ b/WebCore/khtml/html/html_baseimpl.cpp
@@ -56,6 +56,7 @@ HTMLBodyElementImpl::HTMLBodyElementImpl(DocumentPtr *doc)
 HTMLBodyElementImpl::~HTMLBodyElementImpl()
 {
     if (m_linkDecl) {
+        m_linkDecl->setNode(0);
         m_linkDecl->setParent(0);
         m_linkDecl->deref();
     }

diff --git a/WebCore/khtml/html/html_elementimpl.cpp b/WebCore/khtml/html/html_elementimpl.cpp
index 1e7ccf996ed6a73ad0a92f86ddfeb8418d046ea6..28d76063cdd88744ec6ff278d2300b4c3702f004 100644 (file)
--- a/WebCore/khtml/html/html_elementimpl.cpp
+++ b/WebCore/khtml/html/html_elementimpl.cpp
@@ -213,6 +213,7 @@ HTMLElementImpl::HTMLElementImpl(DocumentPtr *doc)
 HTMLElementImpl::~HTMLElementImpl()
 {
     if (m_inlineStyleDecl) {
+        m_inlineStyleDecl->setNode(0);
         m_inlineStyleDecl->setParent(0);
         m_inlineStyleDecl->deref();
     }