2011-03-30 Erik Arvidsson <arv@chromium.org>
authorarv@chromium.org <arv@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Mar 2011 21:06:08 +0000 (21:06 +0000)
committerarv@chromium.org <arv@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Mar 2011 21:06:08 +0000 (21:06 +0000)
        Reviewed by Alexey Proskuryakov.

        Missing DOM bindings for a ping
        https://bugs.webkit.org/show_bug.cgi?id=51955

        * fast/dom/ping-attribute-dom-binding-expected.txt: Added.
        * fast/dom/ping-attribute-dom-binding.html: Added.
2011-03-30  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Missing DOM bindings for a ping
        https://bugs.webkit.org/show_bug.cgi?id=51955

        Test: fast/dom/ping-attribute-dom-binding.html

        * html/HTMLAnchorElement.idl:
        * html/HTMLAreaElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt [new file with mode: 0644]
LayoutTests/fast/dom/ping-attribute-dom-binding.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLAnchorElement.idl
Source/WebCore/html/HTMLAreaElement.idl

index ca06fafe6a99ba39c15e9f2abb534a1d169460a0..c86b470244dfc7156882d1e9cf193828928be492 100644 (file)
@@ -1,3 +1,13 @@
+2011-03-30  Erik Arvidsson  <arv@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Missing DOM bindings for a ping
+        https://bugs.webkit.org/show_bug.cgi?id=51955
+
+        * fast/dom/ping-attribute-dom-binding-expected.txt: Added.
+        * fast/dom/ping-attribute-dom-binding.html: Added.
+
 2011-03-30  Mihai Parparita  <mihaip@chromium.org>
 
         Fix remaining unexpected Chromium Snow Leopard image failures.
diff --git a/LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt b/LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt
new file mode 100644 (file)
index 0000000..5aad0b2
--- /dev/null
@@ -0,0 +1,19 @@
+Tests the DOM bindings for the ping attribute
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS anchor.ping is ""
+PASS anchor.ping is "p1"
+PASS anchor.getAttribute("ping") is "p2"
+PASS anchor.hasAttribute("ping") is false
+PASS anchor.ping is ""
+PASS area.ping is ""
+PASS area.ping is "p1"
+PASS area.getAttribute("ping") is "p2"
+PASS area.hasAttribute("ping") is false
+PASS area.ping is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/dom/ping-attribute-dom-binding.html b/LayoutTests/fast/dom/ping-attribute-dom-binding.html
new file mode 100644 (file)
index 0000000..1f7a8b9
--- /dev/null
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<link rel="stylesheet" href="../js/resources/js-test-style.css">
+<script src="../js/resources/js-test-pre.js"></script>
+</head>
+<body>
+<p id="description"></p>
+<div id="console"></div>
+<script>
+
+description('Tests the DOM bindings for the ping attribute');
+
+var anchor = document.createElement('a');
+shouldBeEqualToString('anchor.ping', '');
+anchor.setAttribute('ping', 'p1');
+shouldBeEqualToString('anchor.ping', 'p1');
+anchor.ping = 'p2';
+shouldBeEqualToString('anchor.getAttribute("ping")', 'p2');
+anchor.ping = null;
+shouldBeFalse('anchor.hasAttribute("ping")');
+shouldBeEqualToString('anchor.ping', '');
+
+var area = document.createElement('area');
+shouldBeEqualToString('area.ping', '');
+area.setAttribute('ping', 'p1');
+shouldBeEqualToString('area.ping', 'p1');
+area.ping = 'p2';
+shouldBeEqualToString('area.getAttribute("ping")', 'p2');
+area.ping = null;
+shouldBeFalse('area.hasAttribute("ping")');
+shouldBeEqualToString('area.ping', '');
+
+var successfullyParsed = true;
+
+</script>
+<script src="../js/resources/js-test-post.js"></script>
+</body>
+</html>
index ec7e6ded08ae8938fe061934665482eca772dbbc..1f95888040776f206a79402f0082e36b2a1975d6 100644 (file)
@@ -1,3 +1,15 @@
+2011-03-30  Erik Arvidsson  <arv@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Missing DOM bindings for a ping
+        https://bugs.webkit.org/show_bug.cgi?id=51955
+
+        Test: fast/dom/ping-attribute-dom-binding.html
+
+        * html/HTMLAnchorElement.idl:
+        * html/HTMLAreaElement.idl:
+
 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
 
         Reviewed by Dirk Schulze.
index 432df69cddbc1c27e1a6e3d26b993631f4c85759..8f09e411143a300955cbf3317fb1c67bd9640eb6 100644 (file)
@@ -27,6 +27,7 @@ module html {
         attribute [Reflect, URL] DOMString href;
         attribute [Reflect] DOMString hreflang;
         attribute [Reflect] DOMString name;
+        attribute [Reflect] DOMString ping;
         attribute [Reflect] DOMString rel;
         attribute [Reflect] DOMString rev;
         attribute [Reflect] DOMString shape;
index a77e6150573da908be038399690c717259bb6e82..3358c051a59826931c0985be730e003eca4efd5f 100644 (file)
@@ -26,6 +26,7 @@ module html {
         attribute [Reflect] DOMString coords;
         attribute [Reflect, URL] DOMString href;
         attribute [Reflect] boolean noHref;
+        attribute [Reflect] DOMString ping;
         attribute [Reflect] DOMString shape;
         attribute [Reflect] DOMString target;