Disable the "unreachable-code" warning
authorbenjamin@webkit.org <benjamin@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 21:49:21 +0000 (21:49 +0000)
committerbenjamin@webkit.org <benjamin@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 21:49:21 +0000 (21:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136677

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-09
Reviewed by Darin Adler.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

The warning causes various build errors depending on which Clang you are using.

For example, with recent clangs, it breaks all the ARCHS dependent code like this:
    if (sizeof(uintptr_t) == 4)
        // Something for 32 bits.
    else
        // Somethign for 64 bits.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/Base.xcconfig
Source/ThirdParty/ChangeLog
Source/ThirdParty/gtest/xcode/Config/General.xcconfig
Source/WTF/ChangeLog
Source/WTF/Configurations/Base.xcconfig
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Configurations/Base.xcconfig
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/Base.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/Base.xcconfig

index 6e8fd2b79eda40d928b2ddb05d46e571427270a7..dbc55714fff6538c04e4549c397c6fc7741595a1 100644 (file)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Filip Pizlo  <fpizlo@apple.com>
 
         DFG should have a reusable SSA builder
index a02396a63f5469a08d4441c998e26a40d4cad1c7..1418b078732aff35d905ee7e1c8c79a05eac0ea7 100644 (file)
@@ -32,7 +32,6 @@ CLANG_WARN_CXX0X_EXTENSIONS = NO;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
index 4f1a4710c468bbd8128c54271bfee1ddd4b1835f..bf541835b9d8dbba2578d09ca998c4b01a96e784 100644 (file)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * gtest/xcode/Config/General.xcconfig:
+
 2014-09-06  Darin Adler  <darin@apple.com>
 
         Make updates suggested by new version of Xcode
index 13e1e290f453fbc84b8ed8f92b25b207944c9caf..05be9a209091a51ad578f1bbcc43f93c8f062beb 100644 (file)
@@ -28,7 +28,6 @@ CLANG_WARN_CONSTANT_CONVERSION = YES;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
 GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
index e590b7f31f3bc33a0b7f4f94544a952fd9f27ce0..203738d64e611a41ebeb2b731868548f2bc21a5d 100644 (file)
@@ -1,3 +1,20 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        The warning causes various build errors depending on which Clang you are using.
+
+        For example, with recent clangs, it breaks all the ARCHS dependent code like this:
+            if (sizeof(uintptr_t) == 4)
+                // Something for 32 bits.
+            else
+                // Somethign for 64 bits.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-07  Filip Pizlo  <fpizlo@apple.com>
 
         DFG should have a reusable SSA builder
index c560fcb82fbebca55d5c08cd99d446739c5d09dd..e45781d5f98bcbdf75cc8a9fed9b1f925151b866 100644 (file)
@@ -32,7 +32,6 @@ CLANG_WARN_CXX0X_EXTENSIONS = NO;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
index d0af4d8f7316ca04eafec734f342b792610eed75..504f90966129676b681ef74f9372998889cacc2c 100644 (file)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Fix ESLint no-trailing-spaces warnings
index 9d878b38e7af484718d8fc48d6b88ea690fdc293..305bf917e72b6ee319a9a8f105684242839d79be 100644 (file)
@@ -14,7 +14,6 @@ CLANG_WARN_CXX0X_EXTENSIONS = NO;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
 GCC_C_LANGUAGE_STANDARD = gnu99;
index 2e08edf454bb14eaad46113855737355103faa2e..62399209972cd8770802f9d39919b66c6284786f 100644 (file)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
 
         Fix 32-bit Mac build for new warnings
index f0ba335b918c09e68817187fd174e5563998ce0a..99ba907e16b06f4d472380538249ae34595352a8 100644 (file)
@@ -32,7 +32,6 @@ CLANG_WARN_CXX0X_EXTENSIONS = NO;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
index 6b2dbc617bfa2ebba8a2f0aebcf46ee7fa3baf32..4d906311aa8cbf40ee52d71181b7f2111d4b8d96 100644 (file)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-09  Dan Bernstein  <mitz@apple.com>
 
         [Cocoa] -[WKBackForwardList backList] contains an unnecessary nil check
index 7ff3ed155f8200ed87d4252d9f0f80fd2b94a83f..230aaf9de5efe73fb9b4a298b46867d7ec3b9a24 100644 (file)
@@ -32,7 +32,6 @@ CLANG_WARN_CXX0X_EXTENSIONS = NO;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;