Web Inspector: fix to record button remaining red after heap snapshot is taken
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Feb 2013 12:57:58 +0000 (12:57 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Feb 2013 12:57:58 +0000 (12:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109804

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.

Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/HeapSnapshotView.js
Source/WebCore/inspector/front-end/ProfilesPanel.js

index e92be07117bed88333fe71cb47f0cac591aa707a..ed27b2f07507778468527cfefb1764ff2a8cc826 100644 (file)
@@ -1,3 +1,18 @@
+2013-02-14  Alexei Filippov  <alph@chromium.org>
+
+        Web Inspector: fix to record button remaining red after heap snapshot is taken
+        https://bugs.webkit.org/show_bug.cgi?id=109804
+
+        Reviewed by Yury Semikhatsky.
+
+        Revert part of r142243 fix. Namely heap snapshot taking button made
+        stateless as it was before.
+
+        * inspector/front-end/HeapSnapshotView.js:
+        (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
+        * inspector/front-end/ProfilesPanel.js:
+        (WebInspector.ProfilesPanel.prototype.toggleRecordButton):
+
 2013-02-14  Alexander Pavlov  <apavlov@chromium.org>
 
         Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
index 1720e9a8b1b214053e77af418e939b0fca9e3e48..79379d90e317df746410fdac668327912c522845 100644 (file)
@@ -775,7 +775,7 @@ WebInspector.HeapSnapshotProfileType.prototype = {
     buttonClicked: function(profilesPanel)
     {
         profilesPanel.takeHeapSnapshot();
-        return true;
+        return false;
     },
 
     get treeItemTitle()
index 73cd7ccfab2609c0b90a0d3e113aeb85c43e0132..6e7ab4f06c3b02d3f733b8df4d8f5e1bf7c76417 100644 (file)
@@ -358,6 +358,10 @@ WebInspector.ProfilesPanel.prototype = {
         var isProfiling = this._selectedProfileType.buttonClicked(this);
         this.recordButton.toggled = isProfiling;
         this.recordButton.title = this._selectedProfileType.buttonTooltip;
+        if (isProfiling)
+            this._launcherView.profileStarted();
+        else
+            this._launcherView.profileFinished();
     },
 
     wasShown: function()