Remove initProgressEvent method

https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

* dom/ProgressEvent.cpp:
* dom/ProgressEvent.h:
* dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 26c7ed65381a68d7e49f612dad4d9c5bf58e63a6..695b0ff5338cb6249ada0a44b55d4783b8352664 100755 (executable)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,24 @@
+2011-11-17  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        Remove initProgressEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71340
+
+        Reviewed by Adam Barth.
+
+        This method has been removed from the spec draft.
+        http://www.w3.org/TR/progress-events/#interface-progressevent
+
+        No new tests. Removed method. Updated expected results.
+
+        * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+        * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+        * fast/events/init-events-expected.txt:
+        * fast/events/script-tests/init-events.js:
+        * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+
 2011-11-17  Adam Klein  <adamk@chromium.org>
 
         Move JS recursion counter from V8Proxy to V8BindingPerIsolateData

diff --git a/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt b/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
index 68b5b670d99839c2c425da4b391a26ae064911bf..97bf1e0671237e60633c66f0c1388c167614228f 100644 (file)
--- a/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
+++ b/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
@@ -51,8 +51,6 @@ PASS nonNumericPolicy('document.createEvent("MouseEvent").initMouseEvent("a", fa
 PASS nonNumericPolicy('document.body.attributes.item(x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createNodeIterator(document, x, null, false)') is 'any type allowed'
 PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed'
-PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, x, 0)') is 'any type allowed'
-PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, 0, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().setStart(document, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().setEnd(document, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().comparePoint(document, x)') is 'any type allowed'

diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
index dd400f633322a8fa8ca047176264f677952e1761..2e7006c5a9f2d49221ebf34299403a18f0bf9a6d 100644 (file)
--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
@@ -301,11 +301,6 @@ shouldBe("nonNumericPolicy('document.createNodeIterator(document, x, null, false
 
 shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed'");
 
-// ProgressEvent
-
-shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, x, 0)')", "'any type allowed'");
-shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, 0, x)')", "'any type allowed'");
-
 // Range
 
 shouldBe("nonNumericPolicy('document.createRange().setStart(document, x)')", "'any type allowed'");

diff --git a/LayoutTests/fast/events/init-events-expected.txt b/LayoutTests/fast/events/init-events-expected.txt
index 43354e13ca8b9a1360f7c2430ebe96d084523bb5..f4c01beb578ffa754a33490eae2751c31d9e5b09 100644 (file)
--- a/LayoutTests/fast/events/init-events-expected.txt
+++ b/LayoutTests/fast/events/init-events-expected.txt
@@ -116,16 +116,6 @@ PASS testInitEvent('Mutation', '"a", false, false, null, "b", null, "d", 1001').
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrName is 'd'
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", null, 1001').attrName is 'null'
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrChange is 1001
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').type is 'a'
-PASS testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type is 'null'
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').bubbles is false
-PASS testInitEvent('Progress', '"a", true, false, false, 1001, 1002').bubbles is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').cancelable is false
-PASS testInitEvent('Progress', '"a", false, true, false, 1001, 1002').cancelable is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').lengthComputable is false
-PASS testInitEvent('Progress', '"a", false, false, true, 1001, 1002').lengthComputable is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').loaded is 1001
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').total is 1002
 PASS testInitEvent('Storage', '"a", false, false, "b", "c", "d", "e"').type is 'a'
 PASS testInitEvent('Storage', 'null, false, false, "b", "c", "d", "e"').type is 'null'
 PASS testInitEvent('Storage', '"a", false, false, "b", "c", "d", "e"').bubbles is false

diff --git a/LayoutTests/fast/events/script-tests/init-events.js b/LayoutTests/fast/events/script-tests/init-events.js
index 24110be0abb4ae8d89528c1b576e7fadbc07bfa0..c7cab595204cd50ec1e4738b6e8423b66233a977 100644 (file)
--- a/LayoutTests/fast/events/script-tests/init-events.js
+++ b/LayoutTests/fast/events/script-tests/init-events.js
@@ -130,17 +130,6 @@ shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", \"
 shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", null, 1001').attrName", "'null'");
 shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", \"d\", 1001').attrChange", "1001");
 
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').type", "'a'");
-shouldBe("testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type", "'null'");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').bubbles", "false");
-shouldBe("testInitEvent('Progress', '\"a\", true, false, false, 1001, 1002').bubbles", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').cancelable", "false");
-shouldBe("testInitEvent('Progress', '\"a\", false, true, false, 1001, 1002').cancelable", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').lengthComputable", "false");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, true, 1001, 1002').lengthComputable", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').loaded", "1001");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').total", "1002");
-
 shouldBe("testInitEvent('Storage', '\"a\", false, false, \"b\", \"c\", \"d\", \"e\"').type", "'a'");
 shouldBe("testInitEvent('Storage', 'null, false, false, \"b\", \"c\", \"d\", \"e\"').type", "'null'");
 shouldBe("testInitEvent('Storage', '\"a\", false, false, \"b\", \"c\", \"d\", \"e\"').bubbles", "false");

diff --git a/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt b/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
index 00d99a407e16779e3d1d7f1f7fbe15f0345e91bf..d0d25249eb039f8e6256408f36b17dc980ecca5f 100644 (file)
--- a/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
+++ b/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
@@ -52,9 +52,6 @@ eventPhase : '2'
 initEvent : 'function initEvent() {
     [native code]
 }'
-initProgressEvent : 'function initProgressEvent() {
-    [native code]
-}'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

diff --git a/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt b/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
index 1ee9d7e93384db460b22cca2ef8d5e899870a930..bb68e6d41f86730c0b4001aa57a3968c59d5200f 100644 (file)
--- a/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
+++ b/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
@@ -50,7 +50,6 @@ currentTarget : '[object XMLHttpRequest]'
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

diff --git a/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt b/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
index 1ee9d7e93384db460b22cca2ef8d5e899870a930..bb68e6d41f86730c0b4001aa57a3968c59d5200f 100644 (file)
--- a/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
+++ b/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
@@ -50,7 +50,6 @@ currentTarget : '[object XMLHttpRequest]'
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

diff --git a/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt b/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
index 1ee9d7e93384db460b22cca2ef8d5e899870a930..bb68e6d41f86730c0b4001aa57a3968c59d5200f 100644 (file)
--- a/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
+++ b/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
@@ -50,7 +50,6 @@ currentTarget : '[object XMLHttpRequest]'
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 1e8f2ab070f4ebb1d6c7e91fbb878e9916ebcaae..d791e7fd3cf119a418c873311abc3dc938b29cbf 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2011-11-17  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        Remove initProgressEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71340
+
+        Reviewed by Adam Barth.
+
+        This method has been removed from the spec draft.
+        http://www.w3.org/TR/progress-events/#interface-progressevent
+
+        No new tests. Removed method.
+
+        * dom/ProgressEvent.cpp:
+        * dom/ProgressEvent.h:
+        * dom/ProgressEvent.idl:
+
 2011-11-17  Eunmi Lee  <eunmi15.lee@samsung.com>
 
         [EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the

diff --git a/Source/WebCore/dom/ProgressEvent.cpp b/Source/WebCore/dom/ProgressEvent.cpp
index 64f0a7b2c7e8ac6d7520ace6ca3954c0f53fc83b..fe8351bc15a017f1a73ad7d5b41ca454e315e475 100644 (file)
--- a/Source/WebCore/dom/ProgressEvent.cpp
+++ b/Source/WebCore/dom/ProgressEvent.cpp
@@ -60,19 +60,6 @@ ProgressEvent::ProgressEvent(const AtomicString& type, bool lengthComputable, un
 {
 }
     
-void ProgressEvent::initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
-    bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg)
-{    
-    if (dispatched())
-        return;
-
-    initEvent(typeArg, canBubbleArg, cancelableArg);
-
-    m_lengthComputable = lengthComputableArg;
-    m_loaded = loadedArg;
-    m_total = totalArg;
-}
-
 const AtomicString& ProgressEvent::interfaceName() const
 {
     return eventNames().interfaceForProgressEvent;

diff --git a/Source/WebCore/dom/ProgressEvent.h b/Source/WebCore/dom/ProgressEvent.h
index f77999c16e3ba12180fbfe872d7c1a26f106e6df..1824318162ab6064e640fc58f78612735fb865d1 100644 (file)
--- a/Source/WebCore/dom/ProgressEvent.h
+++ b/Source/WebCore/dom/ProgressEvent.h
@@ -53,9 +53,6 @@ public:
         return adoptRef(new ProgressEvent(type, initializer));
     }
 
-    void initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
-        bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg);
-
     bool lengthComputable() const { return m_lengthComputable; }
     unsigned long long loaded() const { return m_loaded; }
     unsigned long long total() const { return m_total; }

diff --git a/Source/WebCore/dom/ProgressEvent.idl b/Source/WebCore/dom/ProgressEvent.idl
index 6933dff9566c7b1b5a1fc160c578cf14c55909b6..3bcdd3d799d7164ecd86150536d1e4470ab4245b 100644 (file)
--- a/Source/WebCore/dom/ProgressEvent.idl
+++ b/Source/WebCore/dom/ProgressEvent.idl
@@ -31,13 +31,6 @@ module events {
         readonly attribute [InitializedByConstructor] boolean lengthComputable;
         readonly attribute [InitializedByConstructor] unsigned long long loaded;
         readonly attribute [InitializedByConstructor] unsigned long long total;
-
-        void initProgressEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
-                               in [Optional=CallWithDefaultValue] boolean canBubbleArg,
-                               in [Optional=CallWithDefaultValue] boolean cancelableArg,
-                               in [Optional=CallWithDefaultValue] boolean lengthComputableArg, 
-                               in [Optional=CallWithDefaultValue] unsigned long long loadedArg, 
-                               in [Optional=CallWithDefaultValue] unsigned long long totalArg);
     };
 
 }