Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks...
authorcblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Oct 2004 17:36:07 +0000 (17:36 +0000)
committercblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Oct 2004 17:36:07 +0000 (17:36 +0000)
        Reviewed by kevin.

        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/Plugins.subproj/WebNetscapePluginPackage.m

index 0f8a16763d4627d3fbdf0d36deca9f33dbd8fc31..231c84371d856511e671b70d1e9cbb4b2c556de8 100644 (file)
@@ -1,3 +1,12 @@
+2004-10-18  Chris Blumenberg  <cblu@apple.com>
+
+       Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks an NSURL
+
+        Reviewed by kevin.
+
+        * Plugins.subproj/WebNetscapePluginPackage.m:
+        (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL
+
 2004-10-18  Chris Blumenberg  <cblu@apple.com>
 
         * DOM.subproj/DOMPrivate.h: change to copied header that was never committed
index dce9aa950da950e6aab2f84147b8837ea75488d0..9a49523c6564c1953ad50d9fc60ec7b436992ba6 100644 (file)
@@ -258,9 +258,7 @@ static TransitionVector tVectorForFunctionPointer(FunctionPointer);
 
     // Check if the executable is Mach-O or CFM.
     if (bundle) {
-        NSURL *executableURL = (NSURL *)CFBundleCopyExecutableURL([bundle _cfBundle]);
-        NSFileHandle *executableFile = [NSFileHandle fileHandleForReadingAtPath:[executableURL path]];
-        [executableURL release];
+        NSFileHandle *executableFile = [NSFileHandle fileHandleForReadingAtPath:[bundle executablePath]];
         NSData *data = [executableFile readDataOfLength:8];
         [executableFile closeFile];
         // Check the length of the data before calling memcmp. We think this fixes 3782543.