2008-02-05 Holger Freyther <zecke@selfish.org>
Reviewed by Darin.
In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
depends on the order the tests are executed.
Propose to remove willCloseFrame and didlCearWindowObject output from the
FrameLoadDelegate and update the test results. The output of didClearWindowObject
is not interesting for any of the current tests and we have other ways to find
out if a frame was closed or not.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didClearWindowObject):
* DumpRenderTree/win/FrameLoadDelegate.h:
LayoutTest:
2008-02-05 Holger Freyther <zecke@selfish.org>
Reviewed by Darin.
In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
depends on the order the tests are executed.
Propose to remove willCloseFrame and didlCearWindowObject output from the
FrameLoadDelegate and update the test results. The output of didClearWindowObject
is not interesting for any of the current tests and we have other ways to find
out if a frame was closed or not.
* http/tests/loading/bad-scheme-subframe-expected.txt:
* http/tests/loading/bad-server-subframe-expected.txt:
* http/tests/loading/basic-expected.txt:
* http/tests/loading/empty-subframe-expected.txt:
* http/tests/loading/gmail-assert-on-load-expected.txt:
* http/tests/loading/onload-vs-immediate-refresh-expected.txt:
* http/tests/loading/slow-parsing-subframe-expected.txt:
* platform/mac/http/tests/loading/simple-subframe-expected.txt:
* webarchive/loading/test-loading-archive-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2008-02-05 Holger Freyther <zecke@selfish.org>
+
+ Reviewed by Darin.
+
+ In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
+ the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
+ depends on the order the tests are executed.
+
+ Propose to remove willCloseFrame and didlCearWindowObject output from the
+ FrameLoadDelegate and update the test results. The output of didClearWindowObject
+ is not interesting for any of the current tests and we have other ways to find
+ out if a frame was closed or not.
+
+ * http/tests/loading/bad-scheme-subframe-expected.txt:
+ * http/tests/loading/bad-server-subframe-expected.txt:
+ * http/tests/loading/basic-expected.txt:
+ * http/tests/loading/empty-subframe-expected.txt:
+ * http/tests/loading/gmail-assert-on-load-expected.txt:
+ * http/tests/loading/onload-vs-immediate-refresh-expected.txt:
+ * http/tests/loading/slow-parsing-subframe-expected.txt:
+ * platform/mac/http/tests/loading/simple-subframe-expected.txt:
+ * webarchive/loading/test-loading-archive-expected.txt:
+
2008-02-05 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
main frame - didStartProvisionalLoadForFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didFinishLoadForFrame
This is a test of load callbacks. It is only useful inside the regression test tool.
main frame - didStartProvisionalLoadForFrame
-frame "f1" - willCloseFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "f1" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didStartProvisionalLoadForFrame
-frame "f1" - willCloseFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didFinishLoadForFrame
main frame - didStartProvisionalLoadForFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "f1" - didStartProvisionalLoadForFrame
-frame "f1" - willCloseFrame
frame "f1" - didCommitLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
frame "f1" - didFinishDocumentLoadForFrame
main frame - didStartProvisionalLoadForFrame
-frame "f1" - willCloseFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - willCloseFrame
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didClearWindowObjectForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.
main frame - didStartProvisionalLoadForFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didFinishLoadForFrame
main frame - didStartProvisionalLoadForFrame
-frame "f1" - willCloseFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "f1" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
-frame "f1" - willCloseFrame
frame "f1" - didCommitLoadForFrame
-frame "f1" - didClearWindowObjectForFrame
frame "f1" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
frame "f1" - didFinishDocumentLoadForFrame
main frame - didStartProvisionalLoadForFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "f1" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
-frame "f1" - willCloseFrame
frame "f1" - didCommitLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didStartProvisionalLoadForFrame
-main frame - willCloseFrame
main frame - didCommitLoadForFrame
-main frame - didClearWindowObjectForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
resources/helloworld.webarchive - willSendRequest <NSURLRequest resources/helloworld.webarchive> redirectResponse (null)
main frame - didFinishDocumentLoadForFrame
<unknown> - didFinishLoading
resources/helloworld.webarchive - didReceiveResponse <NSURLResponse resources/helloworld.webarchive>
-frame "<!--framePath //<!--frame0-->-->" - willCloseFrame
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
+2008-02-05 Holger Freyther <zecke@selfish.org>
+
+ Reviewed by Darin.
+
+ In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
+ the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
+ depends on the order the tests are executed.
+
+ Propose to remove willCloseFrame and didlCearWindowObject output from the
+ FrameLoadDelegate and update the test results. The output of didClearWindowObject
+ is not interesting for any of the current tests and we have other ways to find
+ out if a frame was closed or not.
+
+ * DumpRenderTree/mac/FrameLoadDelegate.mm:
+ * DumpRenderTree/win/FrameLoadDelegate.cpp:
+ (FrameLoadDelegate::didClearWindowObject):
+ * DumpRenderTree/win/FrameLoadDelegate.h:
+
2008-02-04 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
- (void)webView:(WebView *)sender didClearWindowObject:(WebScriptObject *)obj forFrame:(WebFrame *)frame
{
- if (!done && layoutTestController->dumpFrameLoadCallbacks()) {
- NSString *string = [NSString stringWithFormat:@"%@ - didClearWindowObjectForFrame", [frame _drt_descriptionSuitableForTestResult]];
- printf ("%s\n", [string UTF8String]);
- }
-
ASSERT(obj == [frame windowObject]);
ASSERT([obj JSObject] == JSContextGetGlobalObject([frame globalContext]));
}
}
-- (void)webView:(WebView *)sender willCloseFrame:(WebFrame *)frame;
-{
- if (!done && layoutTestController->dumpFrameLoadCallbacks()) {
- NSString *string = [NSString stringWithFormat:@"%@ - willCloseFrame", [frame _drt_descriptionSuitableForTestResult]];
- printf ("%s\n", [string UTF8String]);
- }
-}
-
- (void)webView:(WebView *)sender didFinishDocumentLoadForFrame:(WebFrame *)frame;
{
if (!done && layoutTestController->dumpFrameLoadCallbacks()) {
return S_OK;
}
-HRESULT STDMETHODCALLTYPE FrameLoadDelegate::willCloseFrame(
- /* [in] */ IWebView *webView,
- /* [in] */ IWebFrame *frame)
-{
- if (!done && layoutTestController->dumpFrameLoadCallbacks())
- printf("%s - willCloseFrame\n",
- descriptionSuitableForTestResult(frame).c_str());
-
- return S_OK;
-}
-
HRESULT STDMETHODCALLTYPE FrameLoadDelegate::didClearWindowObject(
/* [in] */ IWebView*webView,
/* [in] */ JSContextRef context,
/* [in] */ JSObjectRef windowObject,
/* [in] */ IWebFrame* frame)
{
- if (!done && layoutTestController->dumpFrameLoadCallbacks())
- printf("%s - didClearWindowObjectForFrame\n",
- descriptionSuitableForTestResult(frame).c_str());
-
JSValueRef exception = 0;
::layoutTestController->makeWindowObject(context, windowObject, &exception);
/* [in] */ IWebView *webView,
/* [in] */ IWebFrame *frame) { return E_NOTIMPL; }
- virtual HRESULT STDMETHODCALLTYPE willCloseFrame(
- /* [in] */ IWebView *webView,
- /* [in] */ IWebFrame *frame);
-
virtual HRESULT STDMETHODCALLTYPE windowScriptObjectAvailable(
/* [in] */ IWebView *sender,
/* [in] */ JSContextRef context,