WK1: Update icon for Add to Reading List
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Nov 2014 22:51:25 +0000 (22:51 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Nov 2014 22:51:25 +0000 (22:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138710
<rdar://problem/18975774>

Reviewed by Beth Dakin.

* WebView/WebActionMenuController.mm:
(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
Use the right icon, matching WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebActionMenuController.mm

index 6dc7350e3bd499023271e5c3304b90a2e0d0a1b5..d6f6777ea272a417ebaf1b9793a2862554fdfdcd 100644 (file)
@@ -1,3 +1,15 @@
+2014-11-13  Tim Horton  <timothy_horton@apple.com>
+
+        WK1: Update icon for Add to Reading List
+        https://bugs.webkit.org/show_bug.cgi?id=138710
+        <rdar://problem/18975774>
+
+        Reviewed by Beth Dakin.
+
+        * WebView/WebActionMenuController.mm:
+        (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
+        Use the right icon, matching WebKit2.
+
 2014-11-12  Beth Dakin  <bdakin@apple.com>
 
         WK1: Support default actions for images
 2014-11-12  Beth Dakin  <bdakin@apple.com>
 
         WK1: Support default actions for images
index 9afd3cde157bea0d00158a1c1386f42595b26b49..5916312a012b00da2e4b306afa7d493c97dcb336 100644 (file)
@@ -614,7 +614,7 @@ static DictionaryPopupInfo performDictionaryLookupForRange(Frame* frame, Range&
     case WebActionMenuItemTagAddLinkToSafariReadingList:
         selector = @selector(_addToReadingListFromActionMenu:);
         title = WEB_UI_STRING_KEY("Add to Reading List", "Add to Reading List (action menu item)", "action menu item");
     case WebActionMenuItemTagAddLinkToSafariReadingList:
         selector = @selector(_addToReadingListFromActionMenu:);
         title = WEB_UI_STRING_KEY("Add to Reading List", "Add to Reading List (action menu item)", "action menu item");
-        image = [NSImage imageNamed:NSImageNameBookmarksTemplate];
+        image = [NSImage imageNamed:@"NSActionMenuAddToReadingList"];
         representedObject = [hitTestResult objectForKey:WebElementLinkURLKey];
         break;
 
         representedObject = [hitTestResult objectForKey:WebElementLinkURLKey];
         break;