https://bugs.webkit.org/show_bug.cgi?id=81705
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Mar 2012 11:21:24 +0000 (11:21 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Mar 2012 11:21:24 +0000 (11:21 +0000)
REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-21
Reviewed by Csaba Osztrogonác.

Source/WebCore:

No new tests.

* bindings/js/JSDOMBinding.h: Needs passing globalObject to constructArray().
(WebCore::jsArray):

LayoutTests:

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Reverting test as it passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/bindings/js/JSDOMBinding.h

index 460f5d0134ef4af3482ad95d7eff71d57f354be8..c8a5401f29de11ae3e5ebfad240a4bd3961022db 100644 (file)
@@ -1,3 +1,12 @@
+2012-03-21  Vineet Chaudhary  <rgf748@motorola.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81705
+        REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.
+
+        Reviewed by Csaba Osztrogonác.
+
+        * platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Reverting test as it passes now.
+
 2012-03-21  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening after r111477.
 2012-03-21  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening after r111477.
index c0de484700cb2c3a93310980666fc88df61127ec..f4cfac5ef09119bd3950bf39c50ece02ead72554 100644 (file)
@@ -3,7 +3,7 @@ Make sure prototypes are set up using the window a property came from, instead o
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-FAIL Array from inner.document.forms.testForm.0.ownerDocument.defaultView.console.profiles
+PASS Array from inner.document.forms.testForm.0.ownerDocument.defaultView.console.profiles
 PASS Attr from inner.document.forms.testForm.0.attributes.0
 PASS AttrConstructor from inner.document.forms.testForm.0.attributes.0.constructor
 PASS AttrPrototype from inner.document.forms.testForm.0.attributes.0.__proto__
 PASS Attr from inner.document.forms.testForm.0.attributes.0
 PASS AttrConstructor from inner.document.forms.testForm.0.attributes.0.constructor
 PASS AttrPrototype from inner.document.forms.testForm.0.attributes.0.__proto__
index 1f6bddf15c1d42336415c2c39b5773e558a22e96..1ee684923daf9c41f60531296731f357491039f2 100644 (file)
@@ -1,3 +1,15 @@
+2012-03-21  Vineet Chaudhary  <rgf748@motorola.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81705
+        REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.
+
+        Reviewed by Csaba Osztrogonác.
+
+        No new tests.
+
+        * bindings/js/JSDOMBinding.h: Needs passing globalObject to constructArray().
+        (WebCore::jsArray):
+
 2012-03-21  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
 
         [BlackBerry] Upstreaming blackberry specific css file
 2012-03-21  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
 
         [BlackBerry] Upstreaming blackberry specific css file
index 20a450be827aa6485e76dc360f46c7cb76cb3819..79a3dafd0e64ba5d8b0eb57e8e81e92cec84c3d3 100644 (file)
@@ -288,7 +288,7 @@ enum ParameterDefaultPolicy {
         for (typename Iterable::const_iterator iter = iterator.begin(); iter != end; ++iter)
             list.append(toJS(exec, globalObject, WTF::getPtr(*iter)));
 
         for (typename Iterable::const_iterator iter = iterator.begin(); iter != end; ++iter)
             list.append(toJS(exec, globalObject, WTF::getPtr(*iter)));
 
-        return JSC::constructArray(exec, list);
+        return JSC::constructArray(exec, globalObject, list);
     }
 
     template <class T>
     }
 
     template <class T>