https://bugs.webkit.org/show_bug.cgi?id=76975
Reviewed by Simon Fraser.
Source/WebCore:
This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
* compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
* compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
* platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-01-25 Shawn Singh <shawnsingh@chromium.org>
+
+ Fix the semantics of passing contentsVisible flag to GraphicsLayers
+ https://bugs.webkit.org/show_bug.cgi?id=76975
+
+ Reviewed by Simon Fraser.
+
+ * compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
+ * compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
+ * platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
+
2012-01-25 MORITA Hajime <morrita@google.com>
Unreviewed test fix to followup r105900.
(children 1
(GraphicsLayer
(bounds 800.00 600.00)
- (children 1
+ (children 2
(GraphicsLayer
(bounds 200.00 200.00)
(drawsContent 1)
- (contentsVisible 0)
(children 1
(GraphicsLayer
(bounds 200.00 200.00)
)
)
)
+ (GraphicsLayer
+ (bounds 800.00 15.00)
+ (opacity 0.00)
+ (drawsContent 1)
+ )
)
)
)
(GraphicsLayer
(position 14.00 314.00)
(bounds 757.00 152.00)
- (contentsVisible 0)
(children 1
(GraphicsLayer
(position 20.00 20.00)
After step 1
(GraphicsLayer
- (bounds 785.00 1301.00)
+ (bounds 785.00 1286.00)
(children 1
(GraphicsLayer
- (bounds 785.00 1301.00)
+ (bounds 785.00 1286.00)
(children 3
(GraphicsLayer
(position 14.00 6.00)
(GraphicsLayer
(position 14.00 314.00)
(bounds 757.00 152.00)
- (contentsVisible 0)
(children 1
(GraphicsLayer
(position 20.00 20.00)
After step 2
(GraphicsLayer
- (bounds 785.00 1965.00)
+ (bounds 785.00 1935.00)
(children 1
(GraphicsLayer
- (bounds 785.00 1965.00)
+ (bounds 785.00 1935.00)
(children 3
(GraphicsLayer
(position 14.00 6.00)
(GraphicsLayer
(position 14.00 314.00)
(bounds 757.00 152.00)
- (contentsVisible 0)
(children 1
(GraphicsLayer
(position 20.00 20.00)
// Need to implement file name logging.
BUGWK76572 : http/tests/download = FAIL
-BUGWK76716 : compositing/visibility/layer-visible-content.html = IMAGE+TEXT
-
BUGWK76967 : media/media-fragments/TC0030-TC0039.html = PASS TIMEOUT
BUGABARTH : media/audio-garbage-collect.html = PASS FAIL
+2012-01-25 Shawn Singh <shawnsingh@chromium.org>
+
+ Fix the semantics of passing contentsVisible flag to GraphicsLayers
+ https://bugs.webkit.org/show_bug.cgi?id=76975
+
+ Reviewed by Simon Fraser.
+
+ This patch is covered by existing tests, in particular
+ compositing/visibility/layer-visible-content.html; its
+ expectations are rebaselined.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
2012-01-25 Tony Chang <tony@chromium.org>
support overflow:auto and overflow:scroll in new flexbox
#endif
m_owningLayer->updateVisibilityStatus();
- m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent());
+
+ // m_graphicsLayer is the corresponding GraphicsLayer for this RenderLayer and its non-compositing
+ // descendants. So, the visibility flag for m_graphicsLayer should be true if there are any
+ // non-compositing visible layers.
+ m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent() || m_owningLayer->hasVisibleDescendant());
RenderStyle* style = renderer()->style();
m_graphicsLayer->setPreserves3D(style->transformStyle3D() == TransformStyle3DPreserve3D && !renderer()->hasReflection());