2009-12-07 Darin Fisher <darin@chromium.org>
authordarin@chromium.org <darin@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Dec 2009 22:43:13 +0000 (22:43 +0000)
committerdarin@chromium.org <darin@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Dec 2009 22:43:13 +0000 (22:43 +0000)
        Reviewed by Darin Adler.

        http/tests/cache/subresource-failover-to-network.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=32038

        Rewrite test to avoid dumpResourceLoadCallbacks, which do not
        interleave predictably with the output of dumpFrameLoadCallbacks.
        Other things besides resource loading can delay onload.

        The newly written test uses a cookie to determine if the test has
        passed.

        Unskip this test for platform/win.

        * http/tests/cache/resources/subresource-failover-to-network.cgi:
        * http/tests/cache/subresource-failover-to-network-expected.txt:
        * http/tests/cache/subresource-failover-to-network.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/cache/resources/subresource-failover-to-network.cgi
LayoutTests/http/tests/cache/subresource-failover-to-network-expected.txt
LayoutTests/http/tests/cache/subresource-failover-to-network.html
LayoutTests/platform/win/Skipped

index efd5012c7a22d3efc4374e8284cfa1376eb44abc..c9734b9bca4b095bf72fd10b74f84c82cab53798 100644 (file)
@@ -1,3 +1,24 @@
+2009-12-07  Darin Fisher  <darin@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        http/tests/cache/subresource-failover-to-network.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=32038
+
+        Rewrite test to avoid dumpResourceLoadCallbacks, which do not
+        interleave predictably with the output of dumpFrameLoadCallbacks.
+        Other things besides resource loading can delay onload.
+
+        The newly written test uses a cookie to determine if the test has
+        passed.
+
+        Unskip this test for platform/win.
+
+        * http/tests/cache/resources/subresource-failover-to-network.cgi:
+        * http/tests/cache/subresource-failover-to-network-expected.txt:
+        * http/tests/cache/subresource-failover-to-network.html:
+        * platform/win/Skipped:
+
 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
 
         Reviewed by Darin Adler.
index 834f5c4d3d2a805ce558d1ed02bac21cb4f502c4..6b70b7108f330a3532b691fa59f787179851b9e0 100755 (executable)
@@ -5,9 +5,12 @@ print "\n";
 print <<EOF
 <script>
 try {
+  var result = document.cookie.split(';')[0].split('=')[1];
+  document.cookie = "result=PASS"; // for next time
+
   var r = new XMLHttpRequest();
   r.open('POST', 'echo-no-store.cgi', false);
-  r.send('PASS');
+  r.send(result);
   document.write(r.responseText);
 } catch (e) {
   document.write(e);
index 3aed1f39e1290b659ffdc7c7e810ce953700e2a1..7ef22e9a431ad0272713b71fdc8794016c8ef12f 100644 (file)
@@ -1,39 +1 @@
-main frame - didFinishDocumentLoadForFrame
-main frame - didHandleOnloadEventsForFrame
-main frame - didFinishLoadForFrame
-<unknown> - didFinishLoading
-main frame - didStartProvisionalLoadForFrame
-http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, main document URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http method POST> redirectResponse (null)
-http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http status code 200>
-main frame - didCommitLoadForFrame
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/echo-no-store.cgi, main document URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http method POST> redirectResponse (null)
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/resources/echo-no-store.cgi, http status code 200>
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - didFinishLoading
-main frame - didFinishDocumentLoadForFrame
-main frame - didHandleOnloadEventsForFrame
-main frame - didFinishLoadForFrame
-http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - didFinishLoading
-main frame - didStartProvisionalLoadForFrame
-http://127.0.0.1:8000/cache/subresource-failover-to-network.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/subresource-failover-to-network.html, main document URL http://127.0.0.1:8000/cache/subresource-failover-to-network.html, http method GET> redirectResponse (null)
-http://127.0.0.1:8000/cache/subresource-failover-to-network.html - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/subresource-failover-to-network.html, http status code 200>
-main frame - didCommitLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-main frame - didHandleOnloadEventsForFrame
-main frame - didFinishLoadForFrame
-http://127.0.0.1:8000/cache/subresource-failover-to-network.html - didFinishLoading
-main frame - didStartProvisionalLoadForFrame
-http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, main document URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http method POST> redirectResponse (null)
-http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http status code 200>
-main frame - didCommitLoadForFrame
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/echo-no-store.cgi, main document URL http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi, http method POST> redirectResponse (null)
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/resources/echo-no-store.cgi, http status code 200>
-http://127.0.0.1:8000/cache/resources/echo-no-store.cgi - didFinishLoading
-main frame - didFinishDocumentLoadForFrame
-main frame - didHandleOnloadEventsForFrame
-main frame - didFinishLoadForFrame
 PASS
-
-============== Back Forward List ==============
-        http://127.0.0.1:8000/cache/subresource-failover-to-network.html  **nav target**
-curr->  http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi  **nav target**
-===============================================
index 5aa10500ee110a560c12a0d3f9d0ed4a493f15db..db198eb1074ae94dd544e4ef578469a2d51ce85f 100644 (file)
@@ -2,9 +2,8 @@
 <script>
   if ("layoutTestController" in window) {
     layoutTestController.dumpAsText();
-    layoutTestController.dumpBackForwardList();
-    layoutTestController.dumpFrameLoadCallbacks();
-    layoutTestController.dumpResourceLoadCallbacks();
+
+    document.cookie = "result=FAIL"
 
     // The results of the form submission is a page that performs a non-
     // cacheable sync XHR request.  Upon returning to that page, we expect the
index 76afc0c8d3b147b1060375638a53608c568511c9..bf58cb5cf5daa84718de2364c5f0bd09ce3821d5 100644 (file)
@@ -720,9 +720,6 @@ http/tests/navigation/reload-subframe-iframe.html
 http/tests/plugins/post-url-file.html
 inspector/timeline-network-resource.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=32038 - Flaky on Windows
-http/tests/cache/subresource-failover-to-network.html
-
 # This test requires ogg codecs
 media/media-can-play-ogg.html