https://bugs.webkit.org/show_bug.cgi?id=82004
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove hasGrammarMarker functions, because it is able to work in the
cross-port way through the Internals interface.
No new tests, since we are improving here the infra-structure
for testing a specific method.
* testing/Internals.cpp:
(WebCore::Internals::hasGrammarMarker):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/mac:
Remove hasGrammarMarker support, since it can support in the cross-port way
through the Internals interface.
* WebKit.order:
* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:
Tools:
Remove hasGrammarMarker functions, because it is able to work in the
cross-port way through the Internals interface.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Adjust hasGrammarMarker tests to use Internals instead of LayoutTestController
interface.
* editing/spelling/grammar.html:
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
+
+ Convert hasGrammarMarker to use Internals interface
+ https://bugs.webkit.org/show_bug.cgi?id=82004
+
+ Reviewed by Ryosuke Niwa.
+
+ Adjust hasGrammarMarker tests to use Internals instead of LayoutTestController
+ interface.
+
+ * editing/spelling/grammar.html:
+ * platform/efl/Skipped:
+
2012-03-22 Xingnan Wang <xingnan.wang@intel.com>
Add exception for the setter of "fftSize" in RealtimeAnalyserNode
document.execCommand("InsertText", false, "I have a issue.");
if (window.layoutTestController) {
- if (layoutTestController.hasGrammarMarker(7, 1))
+ if (internals.hasGrammarMarker(document, 7, 1))
log("PASS");
else
log("FAIL");
+2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
+
+ Convert hasGrammarMarker to use Internals interface
+ https://bugs.webkit.org/show_bug.cgi?id=82004
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove hasGrammarMarker functions, because it is able to work in the
+ cross-port way through the Internals interface.
+
+ No new tests, since we are improving here the infra-structure
+ for testing a specific method.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::hasGrammarMarker):
+ (WebCore):
+ * testing/Internals.h:
+ (Internals):
+ * testing/Internals.idl:
+
2012-03-22 Xingnan Wang <xingnan.wang@intel.com>
Add exception for the setter of "fftSize" in RealtimeAnalyserNode
}
#endif // ENABLE(INSPECTOR)
+bool Internals::hasGrammarMarker(Document* document, int from, int length, ExceptionCode&)
+{
+ if (!document || !document->frame())
+ return 0;
+
+ return document->frame()->editor()->selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
+}
+
}
void emitInspectorDidCancelFrame();
bool hasSpellingMarker(Document*, int from, int length, ExceptionCode&);
+ bool hasGrammarMarker(Document*, int from, int length, ExceptionCode&);
static const char* internalsId;
void emitInspectorDidCancelFrame();
boolean hasSpellingMarker(in Document document, in long from, in long length) raises (DOMException);
+ boolean hasGrammarMarker(in Document document, in long from, in long length) raises (DOMException);
readonly attribute InternalSettings settings;
+2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
+
+ Convert hasGrammarMarker to use Internals interface
+ https://bugs.webkit.org/show_bug.cgi?id=82004
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove hasGrammarMarker support, since it can support in the cross-port way
+ through the Internals interface.
+
+ * WebKit.order:
+ * WebView/WebFrame.mm:
+ * WebView/WebFramePrivate.h:
+
2012-03-22 Benjamin Poulain <bpoulain@apple.com>
Build fix for WebHistory is busted after changing time zone
__ZN15WebEditorClient17getGuessesForWordERKN3WTF6StringES3_RNS0_6VectorIS1_Lm0EEE
__ZN3WTF6VectorINS_6StringELm0EE14shrinkCapacityEm
__ZN15WebEditorClient34updateSpellingUIWithMisspelledWordERKN3WTF6StringE
--[WebFrame(WebPrivate) hasGrammarMarker:length:]
__ZThn8_N15WebEditorClient23requestCheckingOfStringEPN7WebCore12SpellCheckerEijRKN3WTF6StringE
__ZN15WebEditorClient23requestCheckingOfStringEPN7WebCore12SpellCheckerEijRKN3WTF6StringE
___copy_helper_block_1
return coreFrame->layerTreeAsText();
}
-- (BOOL)hasGrammarMarker:(int)from length:(int)length
-{
- Frame* coreFrame = core(self);
- if (!coreFrame)
- return NO;
- return coreFrame->editor()->selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
-}
-
- (id)accessibilityRoot
{
#if HAVE(ACCESSIBILITY)
- (NSString*)_layerTreeAsText;
-- (BOOL)hasGrammarMarker:(int)from length:(int)length;
-
// The top of the accessibility tree.
- (id)accessibilityRoot;
+2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
+
+ Convert hasGrammarMarker to use Internals interface
+ https://bugs.webkit.org/show_bug.cgi?id=82004
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove hasGrammarMarker functions, because it is able to work in the
+ cross-port way through the Internals interface.
+
+ * DumpRenderTree/LayoutTestController.cpp:
+ (LayoutTestController::staticFunctions):
+ * DumpRenderTree/LayoutTestController.h:
+ (LayoutTestController):
+ * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+ * DumpRenderTree/mac/LayoutTestControllerMac.mm:
+ * DumpRenderTree/win/LayoutTestControllerWin.cpp:
+ * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
+
2012-03-22 Adam Barth <abarth@webkit.org>
sync-master-with-upstream creates non-linear git history
return JSValueMakeUndefined(context);
}
-static JSValueRef hasGrammarMarkerCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
-{
- if (argumentCount != 2)
- return JSValueMakeUndefined(context);
-
- int from = JSValueToNumber(context, arguments[0], 0);
- int length = JSValueToNumber(context, arguments[1], 0);
- LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
- bool ok = controller->hasGrammarMarker(from, length);
-
- return JSValueMakeBoolean(context, ok);
-}
-
static JSValueRef markerTextForListItemCallback(JSContextRef context, JSObjectRef, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
{ "originsWithApplicationCache", originsWithApplicationCacheCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "goBack", goBackCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "grantDesktopNotificationPermission", grantDesktopNotificationPermissionCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
- { "hasGrammarMarker", hasGrammarMarkerCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "ignoreDesktopNotificationPermissionRequests", ignoreDesktopNotificationPermissionRequestsCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "isCommandEnabled", isCommandEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "isPageBoxVisible", isPageBoxVisibleCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
void abortModal();
- bool hasGrammarMarker(int from, int length);
-
void dumpConfigurationForViewport(int deviceDPI, int deviceWidth, int deviceHeight, int availableWidth, int availableHeight);
static void setSerializeHTTPLoads(bool serialize);
return DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests(BlackBerry::WebKit::DumpRenderTree::currentInstance()->page());
}
-bool LayoutTestController::hasGrammarMarker(int from, int length)
-{
- if (!mainFrame)
- return false;
-
- return mainFrame->editor()->selectionStartHasMarkerFor(WebCore::DocumentMarker::Grammar, from, length);
-}
-
void LayoutTestController::dumpConfigurationForViewport(int deviceDPI, int deviceWidth, int deviceHeight, int availableWidth, int availableHeight)
{
if (!mainFrame)
notImplemented();
}
-bool LayoutTestController::hasGrammarMarker(int, int)
-{
- notImplemented();
- return false;
-}
-
void LayoutTestController::dumpConfigurationForViewport(int deviceDPI, int deviceWidth, int deviceHeight, int availableWidth, int availableHeight)
{
DumpRenderTreeSupportEfl::dumpConfigurationForViewport(browser->mainView(),
{
}
-bool LayoutTestController::hasGrammarMarker(int from, int length)
-{
- return false;
-}
-
void LayoutTestController::dumpConfigurationForViewport(int deviceDPI, int deviceWidth, int deviceHeight, int availableWidth, int availableHeight)
{
WebKitWebView* webView = webkit_web_frame_get_web_view(mainFrame);
[NSApp abortModal];
}
-bool LayoutTestController::hasGrammarMarker(int from, int length)
-{
- return [mainFrame hasGrammarMarker:from length:length];
-}
-
void LayoutTestController::dumpConfigurationForViewport(int /*deviceDPI*/, int /*deviceWidth*/, int /*deviceHeight*/, int /*availableWidth*/, int /*availableHeight*/)
{
{
}
-bool LayoutTestController::hasGrammarMarker(int from, int length)
-{
- // FIXME: Implement this.
- return false;
-}
-
void LayoutTestController::dumpConfigurationForViewport(int /*deviceDPI*/, int /*deviceWidth*/, int /*deviceHeight*/, int /*availableWidth*/, int /*availableHeight*/)
{
// FIXME: Implement this.
{
}
-bool LayoutTestController::hasGrammarMarker(int, int)
-{
- // FIXME: Implement
- return false;
-}
-
void LayoutTestController::dumpConfigurationForViewport(int /*deviceDPI*/, int /*deviceWidth*/, int /*deviceHeight*/, int /*availableWidth*/, int /*availableHeight*/)
{
// FIXME: Implement