Reviewed by Brady.
authoraroben <aroben@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Oct 2006 23:15:54 +0000 (23:15 +0000)
committeraroben <aroben@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Oct 2006 23:15:54 +0000 (23:15 +0000)
        Fix: http://bugs.webkit.org/show_bug.cgi?id=11344
        REGRESSION (r16741): webViewDidChangeSelection delegate not firing in
        2 layout tests

        The behavior for display-none-in-onchange-keyboard is still correct
        (we don't crash when the element about to receive focus gets
        display:none set), so I've just generated new results for it.

        The behavior of tabbing-input-iframe has changed a little. iframe
        elements are now in the tab order, so I've changed the test to take
        that into account and generated new results.

        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
        * fast/forms/tabbing-input-iframe-expected.txt:
        * fast/forms/tabbing-input-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/forms/display-none-in-onchange-keyboard-expected.txt
LayoutTests/fast/forms/tabbing-input-iframe-expected.txt
LayoutTests/fast/forms/tabbing-input-iframe.html

index 453f53da4e159ea68086a341c38fe40ef7988a08..5aa8ac8e8866717700c6b24c2d16b39ba5d74a01 100644 (file)
@@ -1,3 +1,23 @@
+2006-10-18  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Brady.
+
+        Fix: http://bugs.webkit.org/show_bug.cgi?id=11344
+        REGRESSION (r16741): webViewDidChangeSelection delegate not firing in
+        2 layout tests
+
+        The behavior for display-none-in-onchange-keyboard is still correct
+        (we don't crash when the element about to receive focus gets
+        display:none set), so I've just generated new results for it.
+
+        The behavior of tabbing-input-iframe has changed a little. iframe
+        elements are now in the tab order, so I've changed the test to take
+        that into account and generated new results.
+
+        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
+        * fast/forms/tabbing-input-iframe-expected.txt:
+        * fast/forms/tabbing-input-iframe.html:
+
 2006-10-18  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by harrison
index d49a5644458203cba2a8393fbaf0e82e8b7e8bf2..7d1d296220a16cc23fc0ac5bcdff55304f8f142b 100644 (file)
@@ -4,7 +4,6 @@ EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV to 0 of DIV t
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 
 This tests that setting display to 'none' for an element that's about to get focus doesn't crash.
 
index d03fa13d0cafd6182f686f6932abaefcceef4d6b..55b836891b5cc7dace3cc3be25249a6d98357beb 100644 (file)
@@ -23,6 +23,7 @@ layer at (0,0) size 800x600
       RenderTextField {INPUT} at (464,156) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
+      RenderText {#text} at (0,0) size 0x0
 layer at (13,167) size 142x13
   RenderBlock {DIV} at (3,3) size 142x13
 layer at (475,167) size 142x13
index c0bfaf44521b9de7551791f48075d199ab523bdd..92f0082062fbe6dc425e0251230ae8a09097c731 100644 (file)
@@ -5,6 +5,7 @@
         document.getElementById('t1').focus();
         if (window.eventSender) {
             eventSender.keyDown("\t");
+            eventSender.keyDown("\t");
         }
     }
     </script>
@@ -16,4 +17,4 @@
     <iframe style="border: solid thin black"></iframe>
     <input id="t2" value="This should have focus">
 </body>
-</html>
\ No newline at end of file
+</html>