systemHiddenFontFamilySet in DRT is unnecessary
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Apr 2014 22:33:16 +0000 (22:33 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Apr 2014 22:33:16 +0000 (22:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131414

Reviewed by Tim Horton.

It doesn't seem to affect test results on my machine.

* DumpRenderTree/mac/DumpRenderTree.mm:
(drt_NSFontManager_availableFonts):
(systemHiddenFontFamilySet): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm

index e65f11b0a91096b473ce7d73ef77d0dff0b4906c..0b7ad720dbb677df72b19cad9a46e567c42faed6 100644 (file)
@@ -1,3 +1,16 @@
+2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        systemHiddenFontFamilySet in DRT is unnecessary
+        https://bugs.webkit.org/show_bug.cgi?id=131414
+
+        Reviewed by Tim Horton.
+
+        It doesn't seem to affect test results on my machine.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (drt_NSFontManager_availableFonts):
+        (systemHiddenFontFamilySet): Deleted.
+
 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
 
         [Win] Unreviewed test fix: Don't double-release BSTR.
index 43dc828094f01233448915d136c7f8df4c8bce7a..12398746afe1c9476fb1c5b75c5846f7c7a6f28d 100644 (file)
@@ -416,15 +416,6 @@ static NSSet *allowedFontFamilySet()
     return fontFamilySet;
 }
 
-static NSSet *systemHiddenFontFamilySet()
-{
-    static NSSet *fontFamilySet = [[NSSet setWithObjects:
-        @".LucidaGrandeUI",
-        nil] retain];
-
-    return fontFamilySet;
-}
-
 static IMP appKitAvailableFontFamiliesIMP;
 static IMP appKitAvailableFontsIMP;
 
@@ -459,10 +450,6 @@ static NSArray *drt_NSFontManager_availableFonts(id self, SEL _cmd)
         }
     }
 
-    for (NSString *hiddenFontFamily in systemHiddenFontFamilySet()) {
-        [availableFontList addObject:hiddenFontFamily];
-    }
-
     availableFonts = availableFontList;
     return availableFonts;
 }