[EFL] accessibility/aria-invalid is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Sep 2013 15:47:44 +0000 (15:47 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Sep 2013 15:47:44 +0000 (15:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=111986

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-23
Reviewed by Mario Sanchez Prada.

Tools:

Adds possibility to retrieve JS context.
This is part of the implementation of AccessibilityUIElement::addNotificationListener
from 119883 and 120421.

* DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener):
(addAccessibilityNotificationHandler):
(removeAccessibilityNotificationHandler):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):

LayoutTests:

Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.

* platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
* platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl-wk1/TestExpectations
LayoutTests/platform/efl-wk2/TestExpectations
Tools/ChangeLog
Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp

index 0220f4650a8e8a093b5691b7b2ddd9ebf0bec67a..f15b256f65043894cb97165374710dac52e735f3 100644 (file)
@@ -1,3 +1,15 @@
+2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
+
+        [EFL] accessibility/aria-invalid is failing
+        https://bugs.webkit.org/show_bug.cgi?id=111986
+
+        Reviewed by Mario Sanchez Prada.
+
+        Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.
+
+        * platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
+        * platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html
+
 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
 
         [EFL] accessibility/selection-states.html is failing
index c6d6d6f71a349d8efd28a22c1e589325b3689a7d..9571d04e507a0d3636ca14b4ed84e11bcfc7fee0 100644 (file)
@@ -147,7 +147,6 @@ webkit.org/b/117574 editing/selection/selection-actions.html [ ImageOnlyFailure
 webkit.org/b/117574 editing/selection/selection-button-text.html [ ImageOnlyFailure ]
  
 webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
-webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ]
 webkit.org/b/111987 accessibility/aria-link-supports-press.html [ Failure ]
 webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
index abe4d501c175fd5da38eab48c66913bec78c9417..9d3266993bd016ab89176503296d29f0397f77d4 100644 (file)
@@ -158,7 +158,6 @@ webkit.org/b/108355 storage/websql/sql-error-codes.html [ Crash Pass ]
 
 # Missing EFL's accessibility functions
 webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
-webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ]
 webkit.org/b/111987 accessibility/aria-link-supports-press.html [ Failure ]
 webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
index 110a01bdd1af558fb5baefb08278771c2e8142b2..11ada08ae0428b40b8961ecbdaeadc1fe49908a3 100644 (file)
@@ -1,3 +1,22 @@
+2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
+
+        [EFL] accessibility/aria-invalid is failing
+        https://bugs.webkit.org/show_bug.cgi?id=111986
+
+        Reviewed by Mario Sanchez Prada.
+
+        Adds possibility to retrieve JS context.
+        This is part of the implementation of AccessibilityUIElement::addNotificationListener
+        from 119883 and 120421.
+
+        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
+        (axObjectEventListener):
+        (addAccessibilityNotificationHandler):
+        (removeAccessibilityNotificationHandler):
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
+        (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
+
 2013-09-20  Mark Rowe  <mrowe@apple.com>
 
         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
index 4e178943865c135f822637d16542e98a786087c4..7e8982e85e76f3a340aca8afa5e8bd8b39539f11 100644 (file)
@@ -128,6 +128,8 @@ static gboolean axObjectEventListener(GSignalInvocationHint *signalHint, guint n
 
 #if PLATFORM(GTK)
     JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+    JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
 #else
     JSContextRef jsContext = 0;
 #endif
@@ -227,6 +229,8 @@ void addAccessibilityNotificationHandler(AccessibilityNotificationHandler* notif
 
 #if PLATFORM(GTK)
     JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+    JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
 #else
     JSContextRef jsContext = 0;
 #endif
@@ -259,6 +263,8 @@ void removeAccessibilityNotificationHandler(AccessibilityNotificationHandler* no
 
 #if PLATFORM(GTK)
     JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+    JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
 #else
     JSGlobalContextRef jsContext = 0;
 #endif
index 4d154efbcacc570ffdd2fdca936c616bd63c51ef..dcbd9ee8118c6aed64b5f8aa5b7d2cc9d81aab60 100644 (file)
@@ -113,7 +113,7 @@ gboolean axObjectEventListener(GSignalInvocationHint* signalHint, unsigned numPa
     if (loggingAccessibilityEvents)
         printAccessibilityEvent(accessible, signalName.get(), signalValue.get());
 
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
     WKBundlePageRef page = InjectedBundle::shared().page()->page();
     WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
     JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);
@@ -174,7 +174,7 @@ void AccessibilityNotificationHandler::setNotificationFunctionCallback(JSValueRe
 
     m_notificationFunctionCallback = notificationFunctionCallback;
 
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
     WKBundlePageRef page = InjectedBundle::shared().page()->page();
     WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
     JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);
@@ -205,7 +205,7 @@ void AccessibilityNotificationHandler::setNotificationFunctionCallback(JSValueRe
 
 void AccessibilityNotificationHandler::removeAccessibilityNotificationHandler()
 {
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
     WKBundlePageRef page = InjectedBundle::shared().page()->page();
     WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
     JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);