Reviewed by Tim Hatcher.

        - re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view
        remains when search text is deleted

        * WebView/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        I fixed this recently, but then broke it again by adding an early bail-out to this method. So
        now I'm removing the early bail-out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index ea124b11210979a897a46cd66eec3e8efff04e3d..b17085de633aff97a02aff15a6f66ef8f3b0c80a 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2006-04-03  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Tim Hatcher.
+        
+        - re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view 
+        remains when search text is deleted
+
+        * WebView/WebView.m:
+        (-[WebView searchFor:direction:caseSensitive:wrap:]):
+        I fixed this recently, but then broke it again by adding an early bail-out to this method. So
+        now I'm removing the early bail-out.
+
 2006-04-02  Trey Matteson  <trey@usa.net>
 
         Reviewed by Maciej.

diff --git a/WebKit/WebView/WebView.m b/WebKit/WebView/WebView.m
index 46709dd1f4b71284d3d82e02ca63c436bbdd9ec5..401e87335eec52416276afc3d38add69a34677c4 100644 (file)
--- a/WebKit/WebView/WebView.m
+++ b/WebKit/WebView/WebView.m
@@ -2247,9 +2247,6 @@ static WebFrame *incrementFrame(WebFrame *curr, BOOL forward, BOOL wrapFlag)
 
 - (BOOL)searchFor:(NSString *)string direction:(BOOL)forward caseSensitive:(BOOL)caseFlag wrap:(BOOL)wrapFlag
 {
-    if (![string length])
-        return NO;
-    
     // Get the frame holding the selection, or start with the main frame
     WebFrame *startFrame = [self _selectedOrMainFrame];