Reviewed by John.
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Dec 2004 21:13:57 +0000 (21:13 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Dec 2004 21:13:57 +0000 (21:13 +0000)
<rdar://problem/3912979> REGRESSION (125-173): repro crash in HTMLCollectionImpl code (www.clubtravel.ie)

        * khtml/html/html_miscimpl.cpp:
        (HTMLCollectionImpl::traverseNextItem): Pass base when traversing
the initial one step, otherwise we might inadvertantly step
outside the collection base, thereby causing assertion failures or
other badness later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/html/html_miscimpl.cpp

index 9eb1d7971383e42c040c5edd57a7474c1fe30793..a1d450fa92c047184dc32740988fc97f6ccb973b 100644 (file)
@@ -1,3 +1,15 @@
+2004-12-10  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by John.
+
+       <rdar://problem/3912979> REGRESSION (125-173): repro crash in HTMLCollectionImpl code (www.clubtravel.ie)
+
+        * khtml/html/html_miscimpl.cpp:
+        (HTMLCollectionImpl::traverseNextItem): Pass base when traversing
+       the initial one step, otherwise we might inadvertantly step
+       outside the collection base, thereby causing assertion failures or
+       other badness later.
+
 2004-12-10  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by Chris
index 88278fd57f9043395d29bc243f7dec28eab644dd..8792851459855bf54d7345fd896d69779e7f2898 100644 (file)
@@ -103,7 +103,7 @@ void HTMLCollectionImpl::resetCollectionInfo() const
 
 NodeImpl *HTMLCollectionImpl::traverseNextItem(NodeImpl *current) const
 {
-    current = current->traverseNextNode();
+    current = current->traverseNextNode(base);
 
     while (current) {
         if(current->nodeType() == Node::ELEMENT_NODE) {