Turn on CSS Filters on Windows
authoraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Feb 2012 22:50:42 +0000 (22:50 +0000)
committeraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Feb 2012 22:50:42 +0000 (22:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
Source/WebCore/ChangeLog
Source/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd
Source/WebCore/css/CSSPropertyNames.in
Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops

index bc067099b8db08a69a98ccbaa3fc909a9ac2e992..f46fc64ec7abdc82d4caa19ff399ecb442f35cf1 100644 (file)
@@ -1,3 +1,14 @@
+2012-02-02  Chris Marrin  <cmarrin@apple.com>
+
+        Turn on CSS Filters on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=76667
+
+        Skipped filter test files not supported on Windows
+
+        Reviewed by Adele Peterson.
+
+        * platform/win/Skipped:
+
 2012-02-02  Oliver Hunt  <oliver@apple.com>
 
         Getters and setters cause line numbers in errors/console.log to be offset for the whole file
index 3e03de9d3afc2398cb4a95c7b300833c22b64f67..82519f59673c2feea11b3c1e2b9ce32a5adad241 100644 (file)
@@ -37,6 +37,15 @@ css3/filters/effect-opacity-hw.html
 css3/filters/effect-saturate-hw.html
 css3/filters/effect-sepia-hw.html
 
+# Custom filters not yet supported on Windows
+css3/filters/custom-filter-property-computed-style.html
+css3/filters/custom-filter-property-parsing.html
+css3/filters/custom-filter-property-parsing-invalid.html
+css3/filters/custom-filter-shader-cache.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=77645
+css3/filters/filtered-compositing-descendant.html
+
 # Should be moved to platform/mac <rdar://5621425>
 http/tests/misc/willCacheResponse-delegate-callback.html
 
index a727fa708fd627a016c87ca740a00bbf22cabab8..3d10b4f643a6a6964486ba44347bfaa98c89ddeb 100644 (file)
@@ -1,3 +1,17 @@
+2012-02-02  Chris Marrin  <cmarrin@apple.com>
+
+        Turn on CSS Filters on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=76667
+
+        Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors
+
+        Reviewed by Adele Peterson.
+
+        * WebCore.vcproj/copyForwardingHeaders.cmd:
+        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
+        (PlatformCALayer::setFilters):
+        (PlatformCALayer::filtersCanBeComposited):
+
 2012-02-02  Jon Lee  <jonlee@apple.com>
 
         Clear shown notifications when context is no longer active
index eea72c305ff6081975e17ffadd557c80a7fc5f72..24934739471a3ac2b9dc5633cfe74793048d3d57 100755 (executable)
@@ -40,6 +40,7 @@ xcopy /y /d "%ProjectDir%..\platform\cf\*.h" "%CONFIGURATIONBUILDDIR%\include\We
 xcopy /y /d "%ProjectDir%..\platform\cf\win\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
 xcopy /y /d "%ProjectDir%..\platform\graphics\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
 xcopy /y /d "%ProjectDir%..\platform\graphics\%1\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
+xcopy /y /d "%ProjectDir%..\platform\graphics\filters\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
 xcopy /y /d "%ProjectDir%..\platform\graphics\transforms\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
 xcopy /y /d "%ProjectDir%..\platform\graphics\ca\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
 xcopy /y /d "%ProjectDir%..\platform\graphics\ca\win\*.h" "%CONFIGURATIONBUILDDIR%\include\WebCore"
index ceb2798ecf39b8b6c92432bac563192d8031f376..723098dce6a9a9569f18bdeec440bdcb536c6a68 100644 (file)
@@ -375,4 +375,4 @@ z-index
 #if defined(ENABLE_CSS_GRID_LAYOUT) && ENABLE_CSS_GRID_LAYOUT
 -webkit-grid-columns
 -webkit-grid-rows
-#endif
+#endif
\ No newline at end of file
index 4a9a335996518cf0ebf3606d6937839e256b4c0f..47de3f87123d4d318427846166a78f9203481c8e 100644 (file)
@@ -566,6 +566,15 @@ void PlatformCALayer::setOpacity(float value)
     setNeedsCommit();
 }
 
+void PlatformCALayer::setFilters(const FilterOperations&)
+{
+}
+
+bool PlatformCALayer::filtersCanBeComposited(const FilterOperations&)
+{
+    return false;
+}
+
 String PlatformCALayer::name() const
 {
     return CACFLayerGetName(m_layer.get());
index 53afc69dea5416e2be73d7b776c87a3c7bf3ca40..c68b76a7889eb74da707f3d5bfa292a018214113 100644 (file)
@@ -1,3 +1,14 @@
+2012-02-02  Chris Marrin  <cmarrin@apple.com>
+
+        Turn on CSS Filters on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=76667
+
+        Turned on CSS_FILTERS for Windows
+
+        Reviewed by Adele Peterson.
+
+        * win/tools/vsprops/FeatureDefines.vsprops:
+
 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r106566.
index d44c7b990be3314af4628ef9417e8a8d883f25e1..73db466508e3488255c1e992d4dcb3c433b0f707 100644 (file)
@@ -48,7 +48,7 @@
        />
   <UserMacro
                Name="ENABLE_CSS_FILTERS"
-               Value=""
+               Value="ENABLE_CSS_FILTERS"
                PerformEnvironmentSet="true"
        />
   <UserMacro