2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
authordglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2009 05:39:44 +0000 (05:39 +0000)
committerdglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2009 05:39:44 +0000 (05:39 +0000)
        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix return types.

        Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

        * bindings/v8/V8Binding.h:
        (WebCore::toInt32): change return type to int
        (WebCore::toFloat): change return type to float.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bindings/v8/V8Binding.h

index f0a1729010af76b242f0e48156518c3aaa59dc87..b77eb71a47a960a5d60a0d8ecefe016679e70a16 100644 (file)
@@ -1,3 +1,16 @@
+2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24261
+        Fix return types.
+
+        Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
+
+        * bindings/v8/V8Binding.h:
+        (WebCore::toInt32): change return type to int
+        (WebCore::toFloat): change return type to float.
+
 2009-03-03  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by John Sullivan.
index c9dc158c171d4cf88a83b1bd5d8b03f4b3053857..6347a5f5e0d2289c00adcc1ab3d47a1f4edd6a44 100644 (file)
 namespace WebCore {
 
     // FIXME: Remove once migration is complete
-    inline bool toInt32(v8::Handle<v8::Value> value)
+    inline int toInt32(v8::Handle<v8::Value> value)
     {
         return ToInt32(value);
     }
 
-    inline bool toFloat(v8::Local<v8::Value> value)
+    inline float toFloat(v8::Local<v8::Value> value)
     {
         return static_cast<float>(value->NumberValue());
     }