WebKit:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 Apr 2004 19:48:00 +0000 (19:48 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 Apr 2004 19:48:00 +0000 (19:48 +0000)
        Reviewed by Dave.

        * WebView.subproj/WebPreferences.m:
        (-[WebPreferences historyIsFrozen]):
        take out OMIT_TIGER_FEATURES ifdeffing, since if we turn this into API
        then we'll probably want it to work in Panther also. To protect Safari users,
        Safari now explicitly sets historyIsFrozen to NO when starting up in Panther.

        * English.lproj/StringsNotToBeLocalized.txt:
        updated for recent changes

WebBrowser:

        - made enough improvements to "Stealth Browsing" to consider this bug fixed:
        <rdar://problem/3184383>: Would like ability to do "stealth browsing" without
        leaving any tracks behind (history, etc.)

        Reviewed by Dave.

        * AppController.m:
        (-[AppController applicationDidFinishLaunching:]):
        call [WebPreferences historyIsFrozen:NO] on Panther so command-line settings of
        this preference won't persist
        (-[AppController confirmEnableStealthMode]):
        new method, puts up a confirmation dialog explaining what stealth mode is, and
        turns stealth mode on if confirmed. I sent mail to Steve Lemay and Ron Brannan
        to discuss the wording of the dialog, among other things.
        (-[AppController toggleStealthMode:]):
        now calls confirmEnableStealthMode when stealth mode is being turned on

        * DownloadProgressEntry.m:
        (-[DownloadProgressEntry setDownloadStage:]):
        always remove successful downloads when they finish when in stealth mode

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        udpated for these changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/English.lproj/StringsNotToBeLocalized.txt
WebKit/WebView.subproj/WebPreferences.m

index 29f29c319da684885c87fe5633f39bfab612a5e4..e2b32a67074d904c4637748ee046958e7bafd471 100644 (file)
@@ -1,3 +1,16 @@
+2004-04-02  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Dave.
+        
+        * WebView.subproj/WebPreferences.m:
+        (-[WebPreferences historyIsFrozen]):
+        take out OMIT_TIGER_FEATURES ifdeffing, since if we turn this into API
+        then we'll probably want it to work in Panther also. To protect Safari users,
+        Safari now explicitly sets historyIsFrozen to NO when starting up in Panther.
+
+        * English.lproj/StringsNotToBeLocalized.txt:
+        updated for recent changes
+
 2004-04-02  Chris Blumenberg  <cblu@apple.com>
 
        Moved the DOM extensions to their own headers
index b25b197325901d81da77efbe9851df499d7a2ca1..6bc01ece2f65750683215c9b0926906fa5eef759 100644 (file)
 "WebKitFantasyFont"
 "WebKitFixedFont"
 "WebKitHistoryAgeInDaysLimit"
+"WebKitHistoryIsFrozen"
 "WebKitHistoryItemLimit"
 "WebKitInitialTimedLayoutDelay"
 "WebKitInitialTimedLayoutEnabled"
index 41f86165af77798b775e27890c4d076b61825c5a..249903a551eaa1b19a74a0eeaae4feb01578f12e 100644 (file)
@@ -52,10 +52,6 @@ NSString *WebPreferencesChangedNotification = @"WebPreferencesChangedNotificatio
 
 #define KEY(x) [(_private->identifier?_private->identifier:@"") stringByAppendingString:x]
 
-#if MAC_OS_X_VERSION_MAX_ALLOWED <= MAC_OS_X_VERSION_10_3
-#define OMIT_TIGER_FEATURES
-#endif
-
 enum { WebPreferencesVersion = 1 };
 
 @interface WebPreferencesPrivate : NSObject
@@ -621,11 +617,7 @@ NS_ENDHANDLER
 
 - (BOOL)historyIsFrozen
 {
-#ifdef OMIT_TIGER_FEATURES
-    return NO;
-#else
     return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitHistoryIsFrozenPreferenceKey];
-#endif
 }
 
 static NSMutableDictionary *webPreferencesInstances = nil;