[ARM] Disable tests that run out of memory
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Mar 2018 11:31:50 +0000 (11:31 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Mar 2018 11:31:50 +0000 (11:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=182699

Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-03-06
Reviewed by Žan Doberšek.

JSTests:

Skip tests that run of of memory. Do not run
modules/module-jit-reachability.js without LLInt to prevent
running out of executable memory.

* modules.yaml:
* modules/module-jit-reachability.js:
* stress/has-own-property-name-cache-string-keys.js:
* stress/has-own-property-name-cache-symbol-keys.js:

Tools:

Add run mode to allow running modules.yaml-tests without
disabling LLInt for specific tests.

* Scripts/run-jsc-stress-tests:

LayoutTests:

Do not run test with LLInt disabled on Linux.

* js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JSTests/ChangeLog
JSTests/modules.yaml
JSTests/modules/module-jit-reachability.js
JSTests/stress/has-own-property-name-cache-string-keys.js
JSTests/stress/has-own-property-name-cache-symbol-keys.js
LayoutTests/ChangeLog
LayoutTests/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js
Tools/ChangeLog
Tools/Scripts/run-jsc-stress-tests

index 3b5692a5c4023842ddac7be3b2c7bfb9389d31f8..32640f0f5f8cde523b93baafd8dbcee3861f9952 100644 (file)
@@ -1,3 +1,19 @@
+2018-03-06  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Skip tests that run of of memory. Do not run
+        modules/module-jit-reachability.js without LLInt to prevent
+        running out of executable memory.
+
+        * modules.yaml:
+        * modules/module-jit-reachability.js:
+        * stress/has-own-property-name-cache-string-keys.js:
+        * stress/has-own-property-name-cache-symbol-keys.js:
+
 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         ASSERTION FAILED: matchContextualKeyword(m_vm->propertyNames->async)
index ab478f1f6449a12fee8d4c61f52900b5d089c5af..5364f7900517295ee703db79244a5613318d6a9d 100644 (file)
@@ -22,4 +22,4 @@
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 - path: modules
-  cmd: runModules
+  cmd: defaultRunModules unless parseRunCommands
index 9f16a4e0b7eac9d2570f7bd04e63e56b7b613452..90b0d7d55c41ed6501c6cdbc03b56d1f0986c28e 100644 (file)
@@ -1,3 +1,5 @@
+//@ noNoLLIntRunModules if $architecture == "arm"
+
 var points = [
   { x: 0, y: 0 },
   { x: 1, y: 1 },
index eab029d856fe3e872bd93fdf79257212157b718a..b366af9bf7c38434676e293e2ec35792da7533fe 100644 (file)
@@ -1,3 +1,5 @@
+//@ skip if $memoryLimited
+
 function assert(b) {
     if (!b)
         throw new Error("Bad assertion.");
index bb99391546539875c0635a1f0a108d45e4f362c5..4e6009fdee58aa195f2f2a2c781c39ae9f7cbcb4 100644 (file)
@@ -1,3 +1,5 @@
+//@ skip if $memoryLimited
+
 function assert(b) {
     if (!b)
         throw new Error("Bad assertion.");
index 59e5b75a2a1db2d1c8520ff48a68d2adf608903e..ca003d8f34e2e2cd6f8ff906ebc02aef4a75f752 100644 (file)
@@ -1,3 +1,14 @@
+2018-03-06  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Do not run test with LLInt disabled on Linux.
+
+        * js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
+
 2018-03-06  Nan Wang  <n_wang@apple.com>
 
         AX: AOM: More accessibility events support
index 022059ff55428fa0fed969b6f3c437c94f9b29ac..8f62435482b0035e07af7046689414e1ae5baa00 100644 (file)
@@ -1,4 +1,4 @@
-//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
+//@ noNoLLIntRunLayoutTest if $architecture == "arm"
 
 description(
 "Tests that performing an OSR entry into a loop with a hoisted structure check, where the loop may clobber the world, works."
index 7425feb887b1f66c3fb8f28c58f4f19dd98980f2..ef78f6a99f3c7bee4f1c54672361662cdd1d25b1 100644 (file)
@@ -1,3 +1,15 @@
+2018-03-06  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Add run mode to allow running modules.yaml-tests without
+        disabling LLInt for specific tests.
+
+        * Scripts/run-jsc-stress-tests:
+
 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         Fix std::make_unique / new[] using system malloc
index 459254514e393b39d34035b73bf840b176747e1f..a186c09fce99bddd869dcdfffcfa64e5f28f69a9 100755 (executable)
@@ -972,14 +972,14 @@ def runES6(mode)
     addRunCommand("default", args, noisyOutputHandler, errorHandler)
 end
 
-def runModules
+def defaultRunModules(noLLInt: true)
     run("default-modules", "-m")
 
     if !$jitTests
         return
     end
 
-    run("no-llint-modules", "-m", "--useLLInt=false")
+    run("no-llint-modules", "-m", "--useLLInt=false") if noLLInt
     run("no-cjit-validate-phases-modules", "-m", "--validateBytecode=true", "--validateGraphAtEachPhase=true", *NO_CJIT_OPTIONS)
     run("dfg-eager-modules", "-m", *EAGER_OPTIONS)
     run("dfg-eager-no-cjit-validate-modules", "-m", "--validateGraph=true", *(NO_CJIT_OPTIONS + EAGER_OPTIONS))
@@ -994,6 +994,10 @@ def runModules
     run("ftl-no-cjit-small-pool-modules", "-m", "--jitMemoryReservationSize=50000", *(FTL_OPTIONS + NO_CJIT_OPTIONS))
 end
 
+def noNoLLIntRunModules
+    defaultRunModules(noLLInt: false)
+end
+
 def runWebAssembly
     return if !$jitTests
     return if !$isFTLPlatform