platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Jan 2013 08:30:34 +0000 (08:30 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Jan 2013 08:30:34 +0000 (08:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=106850

Reviewed by Chris Fleizach.

The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::supportsFocus):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLMeterElement.cpp
Source/WebCore/html/HTMLOutputElement.cpp
Source/WebCore/html/HTMLProgressElement.cpp

index 5ee0b543d2481cce76fc051840e10fb8ff5d057a..39f6ee1789757f1e6b0b3cc4d652e79ca17f4ea1 100644 (file)
@@ -1,3 +1,21 @@
+2013-01-14  Ryosuke Niwa  <rniwa@webkit.org>
+
+        platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
+        https://bugs.webkit.org/show_bug.cgi?id=106850
+
+        Reviewed by Chris Fleizach.
+
+        The bug was caused by some callers of supportsFocus directly calling that of Node.
+        Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
+        called as needed.
+
+        * html/HTMLMeterElement.cpp:
+        (WebCore::HTMLMeterElement::supportsFocus):
+        * html/HTMLOutputElement.cpp:
+        (WebCore::HTMLOutputElement::supportsFocus):
+        * html/HTMLProgressElement.cpp:
+        (WebCore::HTMLProgressElement::supportsFocus):
+
 2013-01-14  Dima Gorbik  <dgorbik@apple.com>
 
         Implement ID selector matching for the WebVTT ::cue pseudo element
index 63ae7a758617f1e6c73851f715669e9bd51fa38b..f59d79ef9cce18cd6ffe74414e28e64d523d75dc 100644 (file)
@@ -74,7 +74,7 @@ bool HTMLMeterElement::childShouldCreateRenderer(const NodeRenderingContext& chi
 
 bool HTMLMeterElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }
 
 void HTMLMeterElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
index 740fd9c21a9a1a557f57c7182bb13f0d073f2458..a83902a5979fc0a98c279424a0b2f12b0863821d 100644 (file)
@@ -58,7 +58,7 @@ const AtomicString& HTMLOutputElement::formControlType() const
 
 bool HTMLOutputElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }
 
 void HTMLOutputElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
index a1cafe7a7f5103bdee81916c8d3e6bcd41567f31..6ae809f5074963685016cfc3b7f7e4812798dd9b 100644 (file)
@@ -90,7 +90,7 @@ void HTMLProgressElement::willAddAuthorShadowRoot()
 
 bool HTMLProgressElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }
 
 void HTMLProgressElement::parseAttribute(const QualifiedName& name, const AtomicString& value)