Add/initialize Settings::developerExtrasEnabled
authoraroben <aroben@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jul 2007 21:16:21 +0000 (21:16 +0000)
committeraroben <aroben@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jul 2007 21:16:21 +0000 (21:16 +0000)
WebCore:

        Add Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebCore.exp:
        * page/Settings.cpp:
        * page/Settings.h:

WebKit:

        Initialize Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

        Initialize Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebView.cpp:
        (WebView::updateWebCoreSettingsFromPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/WebCore.exp
WebCore/page/Settings.cpp
WebCore/page/Settings.h
WebKit/ChangeLog
WebKit/WebView/WebView.mm
WebKit/win/ChangeLog
WebKit/win/WebView.cpp

index d8eabfe8f9c6d9b8cab7c9a4ccc501ee99794acf..89ef18093d8b94bf6fd4add4c8fc8ab315b81d4f 100644 (file)
@@ -1,3 +1,13 @@
+2007-07-17  Adam Roben  <aroben@apple.com>
+
+        Add Settings::developerExtrasEnabled
+
+        Reviewed by Tim.
+
+        * WebCore.exp:
+        * page/Settings.cpp:
+        * page/Settings.h:
+
 2007-07-17  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by Antti.
index f3f3f5948f8ed7f0819a2f52887d83a388d19202..62d297d9e8ed8e7f4a27ff44743d2a229be65b96 100644 (file)
@@ -447,6 +447,7 @@ __ZN7WebCore8Settings22setShowsURLsInToolTipsEb
 __ZN7WebCore8Settings23setDefaultFixedFontSizeEi
 __ZN7WebCore8Settings23setEditableLinkBehaviorENS_20EditableLinkBehaviorE
 __ZN7WebCore8Settings24setTextAreasAreResizableEb
+__ZN7WebCore8Settings25setDeveloperExtrasEnabledEb
 __ZN7WebCore8Settings25setMinimumLogicalFontSizeEi
 __ZN7WebCore8Settings25setPrivateBrowsingEnabledEb
 __ZN7WebCore8Settings25setShouldPrintBackgroundsEb
index f7dddd335f3628d6428d14f7280b14def5c2a65b..05ede61827f070efc1433961b3126e47bf05639f 100644 (file)
@@ -62,6 +62,7 @@ Settings::Settings(Page* page)
     , m_usesPageCache(false)
     , m_showsURLsInToolTips(false)
     , m_forceFTPDirectoryListings(false)
+    , m_developerExtrasEnabled(false)
 {
     // A Frame may not have been created yet, so we initialize the AtomicString 
     // hash before trying to use it.
@@ -272,4 +273,9 @@ void Settings::setForceFTPDirectoryListings(bool force)
     m_forceFTPDirectoryListings = force;
 }
 
+void Settings::setDeveloperExtrasEnabled(bool developerExtrasEnabled)
+{
+    m_developerExtrasEnabled = developerExtrasEnabled;
+}
+
 } // namespace WebCore
index cb0786c665e7707b5af9f1884c31191054933b10..7f4a6f7c4f4ee46c7ecd624f9d179fa82fbe494d 100644 (file)
@@ -127,13 +127,16 @@ namespace WebCore {
 
         void setShowsURLsInToolTips(bool);
         bool showsURLsInToolTips() const { return m_showsURLsInToolTips; }
-        
+
         void setFTPDirectoryTemplatePath(const String&);
         const String& ftpDirectoryTemplatePath() const { return m_ftpDirectoryTemplatePath; }
         
         void setForceFTPDirectoryListings(bool);
         bool forceFTPDirectoryListings() const { return m_forceFTPDirectoryListings; }
         
+        void setDeveloperExtrasEnabled(bool);
+        bool developerExtrasEnabled() const { return m_developerExtrasEnabled; }
+        
     private:
         Page* m_page;
         
@@ -166,6 +169,7 @@ namespace WebCore {
         bool m_usesPageCache: 1;
         bool m_showsURLsInToolTips : 1;
         bool m_forceFTPDirectoryListings : 1;
+        bool m_developerExtrasEnabled : 1;
     };
 
 } // namespace WebCore
index 32eb1674d8775931c4852a3642af2cf9d2809e14..a2fdf3251d1029201d687569d6082fd97765415a 100644 (file)
@@ -1,3 +1,12 @@
+2007-07-17  Adam Roben  <aroben@apple.com>
+
+        Initialize Settings::developerExtrasEnabled
+
+        Reviewed by Tim.
+
+        * WebView/WebView.mm:
+        (-[WebView _updateWebCoreSettingsFromPreferences:]):
+
 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
 
         Build fix.
index 213459b3df2f47a193975eb8f93c77db7606f1b8..50f1462022aa4cb0776f0756439092946943b2f6 100644 (file)
@@ -881,6 +881,7 @@ static bool debugWidget = true;
     settings->setDOMPasteAllowed([preferences isDOMPasteAllowed]);
     settings->setUsesPageCache([self usesPageCache]);
     settings->setShowsURLsInToolTips([preferences showsURLsInToolTips]);
+    settings->setDeveloperExtrasEnabled([WebView _developerExtrasEnabled]);
     if ([preferences userStyleSheetEnabled]) {
         NSString* location = [[preferences userStyleSheetLocation] _web_originalDataAsString];
         settings->setUserStyleSheetLocation([NSURL URLWithString:(location ? location : @"")]);
index b38d999d0b4d6de45ab73917f584bac352703176..ef874836be2164347eadd71fbb11065868e01514 100644 (file)
@@ -1,3 +1,12 @@
+2007-07-17  Adam Roben  <aroben@apple.com>
+
+        Initialize Settings::developerExtrasEnabled
+
+        Reviewed by Tim.
+
+        * WebView.cpp:
+        (WebView::updateWebCoreSettingsFromPreferences):
+
 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
 
         Build fix. 
index e8521d2120596d7498b3253fe8b1e53f8b019236..9776077012ae17bc4840949b09bd85327badfe85 100644 (file)
@@ -1509,6 +1509,10 @@ HRESULT WebView::updateWebCoreSettingsFromPreferences(IWebPreferences* preferenc
 
     settings->setForceFTPDirectoryListings(true);
 
+    // FIXME: make this read a preference like the Mac's WebKitDeveloperExtras
+    // or when Safari's IncludeDebugMenu is set
+    settings->setDeveloperExtrasEnabled(true);
+
     m_mainFrame->invalidate(); // FIXME
 
     return S_OK;