2009-11-27 Adam Barth <abarth@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Nov 2009 18:49:01 +0000 (18:49 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Nov 2009 18:49:01 +0000 (18:49 +0000)
        Reviewed by Eric Seidel.

        Make commit-queue status not throw an exception where there is not
        status
        https://bugs.webkit.org/show_bug.cgi?id=31936

        We need to actually fetch the results of the query to see what's in the
        datastore.

        * CommitQueueStatus/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/CommitQueueStatus/queue_status.py

index c92e3519891b93d5b190c486cbb56418fe3c5750..af56207397298c61f6668caa4a95734c35d09b58 100644 (file)
@@ -1,3 +1,16 @@
+2009-11-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Make commit-queue status not throw an exception where there is not
+        status
+        https://bugs.webkit.org/show_bug.cgi?id=31936
+
+        We need to actually fetch the results of the query to see what's in the
+        datastore.
+
+        * CommitQueueStatus/queue_status.py:
+
 2009-11-27  Adam Barth  <abarth@webkit.org>
 
         Reviewed by Eric Seidel.
index f48e83d1ab4cdd9832a97022f565025ae4322c2d..dbf05a59e565f2ceff2a7da2222479fcd668562d 100644 (file)
@@ -66,9 +66,10 @@ class MainPage(webapp.RequestHandler):
 
 class PatchStatus(webapp.RequestHandler):
     def get(self, queue_name, attachment_id):
-        statuses = QueueStatus.all().filter('queue_name =', queue_name).filter('active_patch_id =', attachment_id).order('-date')
+        statuses = QueueStatus.all().filter('queue_name =', queue_name).filter('active_patch_id =', attachment_id).order('-date').fetch(1)
         if not statuses:
             self.error(404)
+            return
         self.response.out.write(statuses[0].message)