Reviewed by Eric Seidel.
Review tool should work well on iPad
https://bugs.webkit.org/show_bug.cgi?id=58351
On the iPad, the toolbar ends up at some random position in the middle
of the page because of how position:fixed interacts with scrolling on
the iPad. I feel a bit dirty using a user agent detect, but I'm not
sure if there's a better way to detect whether the user agent has this
behavior.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-04-12 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Review tool should work well on iPad
+ https://bugs.webkit.org/show_bug.cgi?id=58351
+
+ On the iPad, the toolbar ends up at some random position in the middle
+ of the page because of how position:fixed interacts with scrolling on
+ the iPad. I feel a bit dirty using a user agent detect, but I'm not
+ sure if there's a better way to detect whether the user agent has this
+ behavior.
+
+ * code-review.js:
+
2011-03-15 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
}
function updateToolbarAnchorState() {
+ // For iPad, we always leave the toolbar at the bottom of the document
+ // because of the iPad's handling of position:fixed and scrolling.
+ if (navigator.platform.indexOf("iPad") != -1)
+ return;
+
var toolbar = $('#toolbar');
// Unanchor the toolbar and then see if it's bottom is below the body's bottom.
toolbar.toggleClass('anchored', false);