2011-04-12 Adam Barth <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Review tool should work well on iPad
        https://bugs.webkit.org/show_bug.cgi?id=58351

        On the iPad, the toolbar ends up at some random position in the middle
        of the page because of how position:fixed interacts with scrolling on
        the iPad.  I feel a bit dirty using a user agent detect, but I'm not
        sure if there's a better way to detect whether the user agent has this
        behavior.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 9858a1cae75de837332359916794242480f29a34..f6492c4f459b82b372f465488e31f3820d0e51d7 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,18 @@
+2011-04-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Review tool should work well on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=58351
+
+        On the iPad, the toolbar ends up at some random position in the middle
+        of the page because of how position:fixed interacts with scrolling on
+        the iPad.  I feel a bit dirty using a user agent detect, but I'm not
+        sure if there's a better way to detect whether the user agent has this
+        behavior.
+
+        * code-review.js:
+
 2011-03-15  David Levin  <levin@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 00fb5d22229f02d926f27fa410835180e0492e8b..776d48ec6d4aa808d009d864ae8af4c3043127b6 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -1036,6 +1036,11 @@ var CODE_REVIEW_UNITTEST;
   }
 
   function updateToolbarAnchorState() {
+    // For iPad, we always leave the toolbar at the bottom of the document
+    // because of the iPad's handling of position:fixed and scrolling.
+    if (navigator.platform.indexOf("iPad") != -1)
+      return;
+
     var toolbar = $('#toolbar');
     // Unanchor the toolbar and then see if it's bottom is below the body's bottom.
     toolbar.toggleClass('anchored', false);