Don't use Element.classList or box-shadow in Leaks Viewer
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Mar 2011 19:42:12 +0000 (19:42 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Mar 2011 19:42:12 +0000 (19:42 +0000)
They aren't supported by Safari 5. Luckily we have substitutes for them!

Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Use -webkit-box-shadow instead of box-shadow.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.urlPromptButtonClicked):
(LeaksViewer._displayURLPrompt):
(LeaksViewer._setLoadingIndicatorHidden):
Use add/removeStyleClass (from utilities.js) instead of Element.classList.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js
Tools/ChangeLog

index befdd29ec4059ab21a8f94252b9943a8c53258c7..99de051813759f85a36448741d3e6b302ac7410b 100644 (file)
@@ -43,7 +43,7 @@
     height: 200px;
     margin: auto;
     background-color: white;
-    box-shadow: 0 5px 10px rgba(0, 0, 0, 0.8);
+    -webkit-box-shadow: 0 5px 10px rgba(0, 0, 0, 0.8);
     padding: 50px 0;
     text-align: center;
 }
index cf07620139a0f5a0d039bb3c49468ae13c67f156..4ff097002221e25b359984b086ea1764d30466fe 100644 (file)
@@ -76,11 +76,11 @@ var LeaksViewer = {
 
     urlPromptButtonClicked: function(e) {
         this._loadLeaksFromURL(document.getElementById("url").value);
-        document.getElementById("url-prompt-container").classList.add("hidden");
+        document.getElementById("url-prompt-container").addStyleClass("hidden");
     },
 
     _displayURLPrompt: function() {
-        document.getElementById("url-prompt-container").classList.remove("hidden");
+        document.getElementById("url-prompt-container").removeStyleClass("hidden");
         document.getElementById("url").focus();
     },
 
@@ -106,9 +106,9 @@ var LeaksViewer = {
 
     _setLoadingIndicatorHidden: function(hidden) {
         if (hidden)
-            this._loadingIndicator.classList.add("hidden");
+            this._loadingIndicator.addStyleClass("hidden");
         else
-            this._loadingIndicator.classList.remove("hidden");
+            this._loadingIndicator.removeStyleClass("hidden");
     },
 
     _updateTitle: function() {
index 38ce2a3e7cdd3b9fd9216400454ca8b51eb4310b..44b5ff998d18cf370556cbae9de78c1e3cde3307 100644 (file)
@@ -1,3 +1,22 @@
+2011-03-09  Adam Roben  <aroben@apple.com>
+
+        Don't use Element.classList or box-shadow in Leaks Viewer
+
+        They aren't supported by Safari 5. Luckily we have substitutes for them!
+
+        Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
+
+        Reviewed by Simon Fraser.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
+        (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
+        (LeaksViewer.urlPromptButtonClicked):
+        (LeaksViewer._displayURLPrompt):
+        (LeaksViewer._setLoadingIndicatorHidden):
+        Use add/removeStyleClass (from utilities.js) instead of Element.classList.
+
 2011-03-09  Adam Roben  <aroben@apple.com>
 
         Add a link to the Leaks Viewer tool on the build.webkit.org homepage