2011-02-01 Ojan Vafai <ojan@chromium.org>
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Feb 2011 01:12:45 +0000 (01:12 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Feb 2011 01:12:45 +0000 (01:12 +0000)
        Reviewed by Mihai Parparita.

        [codereviewtool] extra space at the beginning of lines in side-by-side view
        https://bugs.webkit.org/show_bug.cgi?id=53550

        The newline between the spans turns into user-visible space in side-by-side mode.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/bugs.webkit.org/ChangeLog
Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb

index 039a36d..9f01a70 100644 (file)
@@ -1,5 +1,16 @@
 2011-02-01  Ojan Vafai  <ojan@chromium.org>
 
 2011-02-01  Ojan Vafai  <ojan@chromium.org>
 
+        Reviewed by Mihai Parparita.
+
+        [codereviewtool] extra space at the beginning of lines in side-by-side view
+        https://bugs.webkit.org/show_bug.cgi?id=53550
+
+        The newline between the spans turns into user-visible space in side-by-side mode.
+
+        * PrettyPatch/PrettyPatch.rb:
+
+2011-02-01  Ojan Vafai  <ojan@chromium.org>
+
         Increment version number to cache-bust code-review.js.
 
         * PrettyPatch/PrettyPatch.rb:
         Increment version number to cache-bust code-review.js.
 
         * PrettyPatch/PrettyPatch.rb:
index 4e353fc..553dded 100644 (file)
@@ -417,7 +417,7 @@ body {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=30"></script>
+<script src="code-review.js?version=31"></script>
 EOF
 
     def self.revisionOrDescription(string)
 EOF
 
     def self.revisionOrDescription(string)
@@ -759,7 +759,7 @@ END
         def to_html
             markedUpText = self.text_as_html
             str = "<div class='%s'>\n" % self.classes.join(' ')
         def to_html
             markedUpText = self.text_as_html
             str = "<div class='%s'>\n" % self.classes.join(' ')
-            str += "<span class='from lineNumber'>%s</span><span class='to lineNumber'>%s</span>\n" %
+            str += "<span class='from lineNumber'>%s</span><span class='to lineNumber'>%s</span>" %
                    [@fromLineNumber.nil? ? '&nbsp;' : @fromLineNumber,
                     @toLineNumber.nil? ? '&nbsp;' : @toLineNumber] unless @fromLineNumber.nil? and @toLineNumber.nil?
             str += "<span class='text'>%s</span>\n" % markedUpText
                    [@fromLineNumber.nil? ? '&nbsp;' : @fromLineNumber,
                     @toLineNumber.nil? ? '&nbsp;' : @toLineNumber] unless @fromLineNumber.nil? and @toLineNumber.nil?
             str += "<span class='text'>%s</span>\n" % markedUpText