Reviewed by Dan Bernstein.

        - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in
        form fields other than the one you're typing into

        * WebCoreSupport/WebEditorClient.mm:
        (selectorForKeyEvent):
        correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
        but didn't get updated here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index e862106bc98955d5750dc04f194feb517b2a8a9c..f2b97fe5190334783e3a0662e9dbe9a93bf61039 100644 (file)
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,15 @@
+2007-11-13  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Dan Bernstein.
+        
+        - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in 
+        form fields other than the one you're typing into
+
+        * WebCoreSupport/WebEditorClient.mm:
+        (selectorForKeyEvent):
+        correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
+        but didn't get updated here.
+
 2007-11-12  Josh Aas  <joshmoz@gmail.com>
 
         Reviewed by Darin.

diff --git a/WebKit/mac/WebCoreSupport/WebEditorClient.mm b/WebKit/mac/WebCoreSupport/WebEditorClient.mm
index 3b705c901ecaed3c2f015acc0ac82ca2e3d09201..7d27e91172b4cedf4fd66cb5a033535f5e8db161 100644 (file)
--- a/WebKit/mac/WebCoreSupport/WebEditorClient.mm
+++ b/WebKit/mac/WebCoreSupport/WebEditorClient.mm
@@ -474,14 +474,15 @@ static SEL selectorForKeyEvent(KeyboardEvent* event)
     // FIXME: This helper function is for the auto-fill code so the bridge can pass a selector to the form delegate.  
     // Eventually, we should move all of the auto-fill code down to WebKit and remove the need for this function by
     // not relying on the selector in the new implementation.
+    // The key identifiers are from <http://www.w3.org/TR/DOM-Level-3-Events/keyset.html#KeySet-Set>
     String key = event->keyIdentifier();
     if (key == "Up")
         return @selector(moveUp:);
     if (key == "Down")
         return @selector(moveDown:);
-    if (key == "U+00001B")
+    if (key == "U+001B")
         return @selector(cancel:);
-    if (key == "U+000009") {
+    if (key == "U+0009") {
         if (event->shiftKey())
             return @selector(insertBacktab:);
         return @selector(insertTab:);