Proposal: Require cross-organizational seconds for reviewer nominations

https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

* coding/commit-review-policy.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog
index 14f5a1c1abe66b5b36d93974ee365949819a6c2e..7dd35fa8048fbb46a38b5b976d26d248bcfabc7c 100644 (file)
--- a/Websites/webkit.org/ChangeLog
+++ b/Websites/webkit.org/ChangeLog
@@ -1,3 +1,21 @@
+2011-01-21  David Levin  <levin@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Proposal: Require cross-organizational seconds for reviewer nominations
+        https://bugs.webkit.org/show_bug.cgi?id=47597
+
+        This changes the committer/reviewer policy to require an additional
+        reviewer supporting a reviewer nomination to work for a different
+        company and different project affiliation from the nominee.
+
+        This means reviewer nominations would require four supporting reviewers,
+        one of which knows the reviewer through the community (irc, email, bugs)
+        ensuring that the nominee has the open-source collaboration skills
+        we so highly value here in WebKit.
+
+        * coding/commit-review-policy.html:
+
 2011-01-01  Adam Barth  <abarth@webkit.org>
 
         Reviewed by Eric Seidel.

diff --git a/Websites/webkit.org/coding/commit-review-policy.html b/Websites/webkit.org/coding/commit-review-policy.html
index c78b7dac2f90df0d4a91257b216007433e9425c6..e8adc4f0aea3ab66141275000353f466db1af557 100644 (file)
--- a/Websites/webkit.org/coding/commit-review-policy.html
+++ b/Websites/webkit.org/coding/commit-review-policy.html
@@ -24,7 +24,7 @@ Reviewers will be maintained at webkit.org.</p>
 
 <p>A candidate for WebKit Committer or WebKit Reviewer should
 initially be nominated by a reviewer on the reviewers mailing list, in
-accordance with the criteria below. If at least two more reviewers
+accordance with the criteria below. If the required reviewers (see below)
 second the nomination, then it carries within 5 business days unless
 someone objects. If an objection is raised, the reviewers should
 discuss the matter and try to come to consensus; failing this, the
@@ -70,6 +70,9 @@ manager/employee relationship, just that you work with the potential
 committer closely enough to make sure they follow policy and work well
 with others.</p>
 
+<p>All committer nominations require the support of three reviewers.
+One reviewer nominates, two others second the nomination.</p>
+
 <h3>Criteria for Reviewers</h3>
 
 <p>A WebKit Reviewer should be a person who has shown particularly
@@ -94,6 +97,13 @@ unofficial reviews.</p>
 
 <p>For Reviewer status, there is no supervision exception.</p>
 
+<p>All reviewer nominations require the support of four reviewers. One reviewer
+nominates, three reviewers second. Reviewers should be known in the WebKit
+community as a whole, and not just within their own place of employment or
+just within a specific organized project. Therefore, at least one of the
+four supporting reviewers must not share any company or project affiliations
+with the nominee (other than WebKit itself).</p>
+
 <h3>Suspension and Revocation of Committer or Reviewer Status</h3>
 
 <p>WebKit Committer or WebKit Reviewer status can be revoked by 2/3