Remove some warnings about not implemented methods.

* ResourceHandle::loadsBlocked and ResourceHandle::supportsBufferedData are
  specific to the NS API and won't be implemented on Qt.
* ResourceHandle::bufferedData can not be reached as we return false in
  ResourceHandle::supportsBufferedData.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index d52d1f928f2394652a69d1031dddc8cfb63c3546..e2aedac476c46f66617b8614b081133b9ade74f4 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,18 +1,31 @@
+2007-11-08  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
+
+        Reviewed by Lars Knoll <lars@trolltech.com>.
+
+        Remove some warnings about not implemented methods.
+
+        * ResourceHandle::loadsBlocked and ResourceHandle::supportsBufferedData are
+        specific to the NS API and won't be implemented on Qt.
+        * ResourceHandle::bufferedData can not be reached as we return false in
+        ResourceHandle::supportsBufferedData.
+
+
+        * platform/network/qt/ResourceHandleQt.cpp:
+        (WebCore::ResourceHandle::supportsBufferedData):
+

 2007-11-08  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Cleanup checking for the request method.
 2007-11-08  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Cleanup checking for the request method.

-        
+

         * Check the request method only in QWebNetworkManager::add.
         * Currently HEAD, GET, POST are allowed and for everything else
         QWebNetworkManager::add returns false.
         * Returning false is compatible with ResourceHandle::start and it
         can be used in ResourceHandle::loadResourceSynchronously to generate
         a ResourceError
         * Check the request method only in QWebNetworkManager::add.
         * Currently HEAD, GET, POST are allowed and for everything else
         QWebNetworkManager::add returns false.
         * Returning false is compatible with ResourceHandle::start and it
         can be used in ResourceHandle::loadResourceSynchronously to generate
         a ResourceError

-        

 
 

-        WARNING: NO TEST CASES ADDED OR CHANGED

 
         * platform/network/qt/ResourceHandleQt.cpp:
         (WebCore::ResourceHandle::start):
 
         * platform/network/qt/ResourceHandleQt.cpp:
         (WebCore::ResourceHandle::start):


@@ -23,13 +36,11 @@
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Implement WebCore::callOnMainThread
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Implement WebCore::callOnMainThread

-        
+

         Implemented using a global QObject, that is moved to the main thread
         and then sending a custom event to it.
         Picked a number below QEvent::User but above any other documented value.
         Implemented using a global QObject, that is moved to the main thread
         and then sending a custom event to it.
         Picked a number below QEvent::User but above any other documented value.

-        

 
 

-        WARNING: NO TEST CASES ADDED OR CHANGED

 
         * platform/qt/ThreadingQt.cpp:
         (WebCore::PerformFunctionEvent::PerformFunctionEvent):
 
         * platform/qt/ThreadingQt.cpp:
         (WebCore::PerformFunctionEvent::PerformFunctionEvent):


@@ -42,14 +53,12 @@
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Avoid problems with calling QPainter::begin() on an already active paintdevice
         Reviewed by Lars Knoll <lars@trolltech.com>.
 
         Avoid problems with calling QPainter::begin() on an already active paintdevice

-        
+

         * Partial pick from 6200e04c3e0a77873c3b3f3969b65bc701020326 to avoid getting
         crashes on Qt/Mac 4.4 with QPainter::begin to fail because we already draw.
         * If we are in a layout or need one do not paint. This can happen for the PlatformScrollBar
         used by the ScrollView on a layout triggered by QWebPage::paintEvent.
         * Partial pick from 6200e04c3e0a77873c3b3f3969b65bc701020326 to avoid getting
         crashes on Qt/Mac 4.4 with QPainter::begin to fail because we already draw.
         * If we are in a layout or need one do not paint. This can happen for the PlatformScrollBar
         used by the ScrollView on a layout triggered by QWebPage::paintEvent.

-        

 
 

-        WARNING: NO TEST CASES ADDED OR CHANGED

 
         * platform/qt/WidgetQt.cpp:
         (WebCore::Widget::invalidateRect):
 
         * platform/qt/WidgetQt.cpp:
         (WebCore::Widget::invalidateRect):

diff --git a/WebCore/platform/network/qt/ResourceHandleQt.cpp b/WebCore/platform/network/qt/ResourceHandleQt.cpp
index bb1935c18a5bba8c17395ad6b71ebd7c358c8505..f4033522ddd7ef2d16d32d55d918cf7eebc683ab 100644 (file)
--- a/WebCore/platform/network/qt/ResourceHandleQt.cpp
+++ b/WebCore/platform/network/qt/ResourceHandleQt.cpp
@@ -132,7 +132,6 @@ void ResourceHandle::cancel()
 
 bool ResourceHandle::loadsBlocked()
 {
 
 bool ResourceHandle::loadsBlocked()
 {

-    notImplemented();

     return false;
 }
 
     return false;
 }
 


@@ -144,13 +143,12 @@ bool ResourceHandle::willLoadFromCache(ResourceRequest& request)
 
 bool ResourceHandle::supportsBufferedData()
 {
 
 bool ResourceHandle::supportsBufferedData()
 {

-    notImplemented();

     return false;
 }
 
 PassRefPtr<SharedBuffer> ResourceHandle::bufferedData()
 {
     return false;
 }
 
 PassRefPtr<SharedBuffer> ResourceHandle::bufferedData()
 {

-    notImplemented();
+    ASSERT_NOT_REACHED();

     return 0;
 }
 
     return 0;
 }