2011-04-27 Ilya Tikhonovsky <loislo@chromium.org>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Apr 2011 22:00:06 +0000 (22:00 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Apr 2011 22:00:06 +0000 (22:00 +0000)
        Reviewed by Brian Weinstein.

        Web Inspector: Stop on Exception state does not persist.

        A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
        https://bugs.webkit.org/show_bug.cgi?id=59630

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/ScriptsPanel.js

index 3ab5bec877e90c85f89f3386dd9c8cab2ff2d360..501e5d6ab08d2a0c6230b2d00839bd99ccb5d776 100644 (file)
@@ -1,3 +1,17 @@
+2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Brian Weinstein.
+
+        Web Inspector: Stop on Exception state does not persist.
+
+        A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
+        https://bugs.webkit.org/show_bug.cgi?id=59630
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
+
 2011-04-27  Adrienne Walker  <enne@google.com>
 
         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
index b5a4d92ab090da974d9813b3bc1402a9b544f7a0..9dfb60c48356163ad6f730bc2e94d90d075abad6 100644 (file)
@@ -442,7 +442,7 @@ WebInspector.ScriptsPanel.prototype = {
 
     _debuggerWasEnabled: function()
     {
-        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionStateString);
+        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState);
 
         if (this._debuggerEnabled)
             return;
@@ -711,7 +711,7 @@ WebInspector.ScriptsPanel.prototype = {
                 this._pauseOnExceptionButton.title = WebInspector.UIString("Pause on uncaught exceptions.\nClick to Not pause on exceptions.");
 
             this._pauseOnExceptionButton.state = pauseOnExceptionsState;
-            WebInspector.settings.pauseOnExceptionStateString = pauseOnExceptionsState;
+            WebInspector.settings.pauseOnExceptionState = pauseOnExceptionsState;
         }
         DebuggerAgent.setPauseOnExceptions(pauseOnExceptionsState, callback.bind(this));
     },