2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
authorkov@webkit.org <kov@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Mar 2009 16:35:32 +0000 (16:35 +0000)
committerkov@webkit.org <kov@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Mar 2009 16:35:32 +0000 (16:35 +0000)
        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24423
        Use new soup_message_body_set_accumulate API in soup backend

        Disable accumulating chunks for request_body on file uploads,
        using the new soup API.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/network/soup/ResourceHandleSoup.cpp

index 7d1e8739190788901d80b0801d55fcb09dea3f49..bb395795fa080f7233ab041d5c9906cde0a8b36b 100644 (file)
@@ -5,6 +5,16 @@
         https://bugs.webkit.org/show_bug.cgi?id=24423
         Use new soup_message_body_set_accumulate API in soup backend
 
+        Disable accumulating chunks for request_body on file uploads,
+        using the new soup API.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::ResourceHandle::startHttp):
+
+2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Holger Freyther.
+
         Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
         the new soup_message_body_set_accumulate API in soup.
 
index f2799f3180cb6335be935b77acd7993c6ce109dd..b9a73b58a6a39b0ab7e2e7814f1e27a66cc8ae22 100644 (file)
@@ -448,13 +448,8 @@ bool ResourceHandle::startHttp(String urlString)
              * be (big) files, which we will want to mmap instead of
              * copying into memory; TODO: support upload of non-local
              * (think sftp://) files by using GIO?
-             *
-             * TODO: we can avoid appending all the buffers to the
-             * request_body variable with the following call, but we
-             * need to depend on libsoup > 2.25.4
-             *
-             * soup_message_body_set_accumulate(msg->request_body, FALSE);
              */
+            soup_message_body_set_accumulate(msg->request_body, FALSE);
             for (size_t i = 0; i < numElements; i++) {
                 const FormDataElement& element = httpBody->elements()[i];