Perf dashboard should have a way of marking outliers

https://bugs.webkit.org/show_bug.cgi?id=143466

Reviewed by Chris Dumez.

Address kling's in-person comment to notify users when the new run status is saved in the database.

* public/v2/app.js:
(App.PaneController._selectedItemIsMarkedOutlierDidChange)
* public/v2/chart-pane.css: Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 6936a1e..727991e 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -5,6 +5,19 @@
 
         Reviewed by Chris Dumez.
 
+        Address kling's in-person comment to notify users when the new run status is saved in the database.
+
+        * public/v2/app.js:
+        (App.PaneController._selectedItemIsMarkedOutlierDidChange)
+        * public/v2/chart-pane.css: Fixed a typo.
+
+2015-04-07  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf dashboard should have a way of marking outliers
+        https://bugs.webkit.org/show_bug.cgi?id=143466
+
+        Reviewed by Chris Dumez.
+
         Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
         Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
 

diff --git a/Websites/perf.webkit.org/public/v2/app.js b/Websites/perf.webkit.org/public/v2/app.js
index a711f8b..8202a5d 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.js
+++ b/Websites/perf.webkit.org/public/v2/app.js
@@ -1072,9 +1072,10 @@ App.PaneController = Ember.ObjectController.extend({
             return;
         var pane = this.get('model');
         selectedMeasurement.setMarkedOutlier(!!selectedItemIsMarkedOutlier).then(function () {
+            alert(selectedItemIsMarkedOutlier ? 'Marked the point as an outlier' : 'The point is no longer marked as an outlier');
             pane.refetchRuns();
         }, function (error) {
-            alert(error);
+            alert('Failed to update the status:' + error);
         });
     }.observes('selectedItemIsMarkedOutlier'),
 });

diff --git a/Websites/perf.webkit.org/public/v2/chart-pane.css b/Websites/perf.webkit.org/public/v2/chart-pane.css
index 0064bfc..da28fd1 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/chart-pane.css
+++ b/Websites/perf.webkit.org/public/v2/chart-pane.css
@@ -96,7 +96,7 @@ a.outlier-button.show g.hide-outlier-icon {
 }
 
 .stat-pane,
-.annotation-pane {
+.analysis-pane {
     right: 2.6rem;
     padding: 0;
 }