[EFL] Fix inappropriate move semantics use in parseAndRemoveEnvironments function

https://bugs.webkit.org/show_bug.cgi?id=150544

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-11-01
Reviewed by Darin Adler.

In parseAndRemoveEnvironments function, it declares its paramerter type as rvalue.
But in ProcessLauncher::launchProcess(), the argument of
parseAndRemoveEnvironments still be used after the call of the function.
Currently the rvalue is not assigned to any other variable in parseAndRemoveEnvironments,
so it doesn't lead to runtime error but use of move semantic
is not appropriate semantically in this case.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::parseAndRemoveEnvironments):
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
index 501ebc2337b7cdcfbd82248acb45e766bfb2053a..24fbe3bb87ca2122383c667c2c6a880ad672292d 100644 (file)
--- a/Source/WebKit2/ChangeLog
+++ b/Source/WebKit2/ChangeLog
@@ -1,3 +1,21 @@
+2015-11-01  Joonghun Park  <jh718.park@samsung.com>
+
+        [EFL] Fix inappropriate move semantics use in parseAndRemoveEnvironments function
+        https://bugs.webkit.org/show_bug.cgi?id=150544
+
+        Reviewed by Darin Adler.
+
+        In parseAndRemoveEnvironments function, it declares its paramerter type as rvalue.
+        But in ProcessLauncher::launchProcess(), the argument of
+        parseAndRemoveEnvironments still be used after the call of the function.
+        Currently the rvalue is not assigned to any other variable in parseAndRemoveEnvironments,
+        so it doesn't lead to runtime error but use of move semantic
+        is not appropriate semantically in this case.
+
+        * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
+        (WebKit::parseAndRemoveEnvironments):
+        (WebKit::ProcessLauncher::launchProcess):
+
 2015-11-01  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r191831.

diff --git a/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp b/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp
index 5fdad89364f65fc2751f7f42517581f3328885aa..4c601d2ec325f46f50c20adfa1e63695496f9464 100644 (file)
--- a/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp
+++ b/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp
@@ -65,7 +65,7 @@ static Vector<std::unique_ptr<char[]>> createArgsArray(const String& prefix, con
     return args;
 }
 
-static void parseAndRemoveEnvironments(Vector<std::unique_ptr<char[]>>&& args)
+static void parseAndRemoveEnvironments(Vector<std::unique_ptr<char[]>>& args)
 {
     // Handle environment variable specified before executable file name only for this process use.
     auto end = args.end();
@@ -135,7 +135,7 @@ void ProcessLauncher::launchProcess()
 #endif
     auto args = createArgsArray(processCmdPrefix, executablePath, String::number(sockets[0]), pluginPath);
 
-    parseAndRemoveEnvironments(WTF::move(args));
+    parseAndRemoveEnvironments(args);
 
     // Do not perform memory allocation in the middle of the fork()
     // exec() below. FastMalloc can potentially deadlock because