+2015-11-01 Joonghun Park <jh718.park@samsung.com>
+
+ [EFL] Fix inappropriate move semantics use in parseAndRemoveEnvironments function
+ https://bugs.webkit.org/show_bug.cgi?id=150544
+
+ Reviewed by Darin Adler.
+
+ In parseAndRemoveEnvironments function, it declares its paramerter type as rvalue.
+ But in ProcessLauncher::launchProcess(), the argument of
+ parseAndRemoveEnvironments still be used after the call of the function.
+ Currently the rvalue is not assigned to any other variable in parseAndRemoveEnvironments,
+ so it doesn't lead to runtime error but use of move semantic
+ is not appropriate semantically in this case.
+
+ * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
+ (WebKit::parseAndRemoveEnvironments):
+ (WebKit::ProcessLauncher::launchProcess):
+
2015-11-01 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r191831.
return args;
}
-static void parseAndRemoveEnvironments(Vector<std::unique_ptr<char[]>>&& args)
+static void parseAndRemoveEnvironments(Vector<std::unique_ptr<char[]>>& args)
{
// Handle environment variable specified before executable file name only for this process use.
auto end = args.end();
#endif
auto args = createArgsArray(processCmdPrefix, executablePath, String::number(sockets[0]), pluginPath);
- parseAndRemoveEnvironments(WTF::move(args));
+ parseAndRemoveEnvironments(args);
// Do not perform memory allocation in the middle of the fork()
// exec() below. FastMalloc can potentially deadlock because