Reviewed by Oliver.
authorandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Nov 2006 21:30:12 +0000 (21:30 +0000)
committerandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Nov 2006 21:30:12 +0000 (21:30 +0000)
        <rdar://problem/4825370>
        REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        Initialize the framework pointer to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView/WebHTMLView.m

index 9729f83e756fcb27874b198879fac632ac2bc693..61b8344e8f2e00fba3812ac0c1ad25311dbd5111 100644 (file)
@@ -1,3 +1,14 @@
+2006-11-08  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Oliver.
+
+        <rdar://problem/4825370>
+        REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
+        
+        * WebView/WebHTMLView.m:
+        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
+        Initialize the framework pointer to 0.
+        
 2006-11-07  Darin Adler  <darin@apple.com>
 
         Reviewed by Geoff.
index 4ff33e84baf3daeba2481a3d80bc8a2da4842f5c..ba2ced1096b16ed4873d6c2a307ea6bbc86c9800 100644 (file)
@@ -1764,7 +1764,7 @@ static WebHTMLView *lastHitView = nil;
     typedef OSStatus (*ServiceWindowShowFunction)(id inWordString, NSRect inWordBoundary, UInt16 inLineDirection);
     static ServiceWindowShowFunction dictionaryServiceWindowShow;
     if (!lookedForFunction) {
-        const struct mach_header *frameworkImageHeader;
+        const struct mach_header *frameworkImageHeader = 0;
         dictionaryServiceWindowShow = reinterpret_cast<ServiceWindowShowFunction>(
             _NSSoftLinkingGetFrameworkFuncPtr(@"ApplicationServices", @"LangAnalysis", "_DCMDictionaryServiceWindowShow", &frameworkImageHeader));
         lookedForFunction = true;